Page MenuHomePhabricator
Create Task
Maniphest T185293

Fix flow-conversion-archive-flow-page-name-format for backwards compatibility
Closed, ResolvedPublic
Actions

Description

rEFLW02dc3605c6b8: Rename to Structured Discussions I: i18n did not take into account that flow-conversion-archive-flow-page-name-format refers to pages, which were not automatically moved by that commit. That means people will be unable to restore their SD boards when re-enabling (it might create new ones; not tested).

Luckily, it already supports newline-separated variations, but this needs to be done in English and all translations.

Like:

-       "flow-conversion-archive-flow-page-name-format": "%s/Structured Discussions Archive %d\n%s/Structured DiscussionsArchive%d",
+       "flow-conversion-archive-flow-page-name-format": "%s/Structured Discussions Archive %d\n%s/Structured DiscussionsArchive%d\n%s/Flow Archive %d\n%s/FlowArchive%d",

But for all languages, checking the actual past translation (not just updating English and having them re-translate, since it might not match).

Details

SubjectRepoBranchLines +/-
Re-add previous patterns to flow archive formatmediawiki/extensions/Flowmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.Jan 19 2018, 9:08 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 19 2018, 9:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Mattflaschen-WMF edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Jan 19 2018, 9:08 AM
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added a subscriber: SBisson.
gerritbot subscribed.Jan 19 2018, 12:03 PM

Change 405277 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Flow@master] Re-add previous patterns to flow archive format

https://gerrit.wikimedia.org/r/405277

gerritbot added a project: Patch-For-Review.Jan 19 2018, 12:03 PM
SBisson added a comment.Jan 19 2018, 12:03 PM

Here's the list of all translations for this message: https://translatewiki.net/w/i.php?title=Special%3ATranslations&message=flow-conversion-archive-flow-page-name-format&namespace=8

There's about 17 that need to be looked at and possibly reverted. I've created the patch for en but I guest everything else should be done on TWN.

SBisson claimed this task.Jan 19 2018, 1:32 PM
SBisson moved this task from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
gerritbot added a comment.Jan 22 2018, 6:58 PM

Change 405277 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Re-add previous patterns to flow archive format

https://gerrit.wikimedia.org/r/405277

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 22 2018, 7:00 PM
SBisson moved this task from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jan 29 2018, 2:31 PM
Etonkovidova closed this task as Resolved.Feb 15 2018, 12:30 AM
Etonkovidova subscribed.

Checked delete/restore SD pages in Article and Talk namespace - seems to be fine.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL