Edit summaries containing multiple autocomments are broken
Closed, ResolvedPublic

Description

Proposed fix for regex in Linker->formatAutocomments

If an edit summary contains more than one autocomment (/* ... */), only the last one is transformed into a section link.

This behavior was introduced by r39594 , though I'm not sure if it was intended this way. In case it wasn't, I attached a quick fix for the regex in Linker->formatAutocomments. A proper solution would probably take a bit more effort. :)


Version: 1.18.x
Severity: minor
URL: http://de.wikipedia.org/w/index.php?title=Wikipedia:Auskunft&dir=prev&offset=20081130183247&limit=1&action=history

attachment autocomments.patch ignored as obsolete

Details

Reference
bz16530
bzimport added a subscriber: Unknown Object (MLST).
bzimport set Reference to bz16530.
P.Copp created this task.Dec 2 2008, 4:29 PM

+need-review

*** Bug 18253 has been marked as a duplicate of this bug. ***

IAlex added a comment.Aug 2 2009, 2:50 PM
  • Bug 15481 has been marked as a duplicate of this bug. ***

sumanah wrote:

I can verify that this is still happening with MediaWiki 1.18, as shown in this test:

https://secure.wikimedia.org/wikipedia/test2/w/index.php?title=Ecology&action=historysubmit&diff=35177&oldid=7899

Paul, could you check to see whether your patch still applies cleanly against trunk, and revise/modify if necessary? Thanks!

sumanah wrote:

I'm sorry for the wait, Paul. Because of the delay in reviewing your contribution, MediaWiki's codebase has changed enough that the patch no longer applies cleanly to trunk. If you revise and update the patch, and mark it with the "patch" and "need-review" keywords, we'll ensure someone reviews it a lot faster. My regrets, again. Thank you.

sumanah wrote:

Comment on attachment 5552
Proposed fix for regex in Linker->formatAutocomments

Per automated testing
http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056340.html patch
no longer applies to MediaWiki trunk in Subversion.

  • Bug 43356 has been marked as a duplicate of this bug. ***

Change 159326 had a related patch set uploaded by Anomie:
Format multiple autocomments in edit summaries

https://gerrit.wikimedia.org/r/159326

Change 159326 had a related patch set uploaded (by Anomie):
Format multiple autocomments in edit summaries

https://gerrit.wikimedia.org/r/159326

Patch-For-Review

Change 159326 merged by jenkins-bot:
Format multiple autocomments in edit summaries

https://gerrit.wikimedia.org/r/159326

Anomie closed this task as "Resolved".Dec 31 2014, 3:31 PM
Anomie claimed this task.

This should be deployed to WMF wikis with 1.25wmf14, see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the schedule.

Add Comment