Regression: Non-existent articles appear blank on mobile EN wikipedia
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	PatchesTheCaveman
	Jan 20 2018, 12:16 AM

Description

When visiting an article that doesn't exist on the Mobile Frontend of the English Wikipedia, instead of seeing the helpful information like typo corrections and links to sister Wikimedia projects that are displayed on the desktop Wikipedia, visitors are instead greeted with a blank page:

Screenshot_20180119-170904.png (1×1 px, 223 KB)

Instead, the helpful information is buried in the Page Issues drop-down:

Screenshot_20180119-171224.png (1×1 px, 156 KB)

I'm not able to reproduce this issue on other wikis. I tried the Spanish Wikipedia, English Wiktionary, and Wikimedia Commons and all showed the article not found text as expected.

Acceptance criteria

Do not run resources/skins.minerva.scripts/cleanuptemplates.js on a non-existent page

Developer replication instructions

The page issues code is being over-zealous.

Edit MediaWiki:Noarticletext with the following

{|class="fmbox"
!
! Page do not exist yo!
|}

Make sure $wgMFContentProviderClass is disabled and visit a non-existent link page

How to test

Get a developer to update staging to disable the MobileFormatter mwApi Content provider
Visit http://reading-web-staging.wmflabs.org/wiki/Frigging_blahaha

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Pages that do not exist cannot have issues	mediawiki/skins/MinervaNeue	master	+6 -2

Customize query in gerrit

Related Objects

Mentioned In: T186829: MobileFrontend mobile.init loadCurrentPage function doesn't pass `isMissing` property

Event Timeline

PatchesTheCaveman created this task.Jan 20 2018, 12:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2018, 12:16 AM

Jdlrobson added a project: Web-Team-Backlog-Archived.Jan 22 2018, 10:49 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson renamed this task from Non-existent articles appear blank on mobile EN wikipedia to Regression: Non-existent articles appear blank on mobile EN wikipedia.Jan 22 2018, 11:20 PM

Jdlrobson removed a project: Local-Wiki-Template-And-Gadget-Issues.

Jdlrobson edited projects, added MinervaNeue, Regression; removed MobileFrontend.

Jdlrobson updated the task description. (Show Details)Jan 29 2018, 7:30 PM

Server side render is fine. The fix is to prevent all this content from appearing under page issues.

https://en.m.wikipedia.org/wiki/Barack_Obama222

Jdlrobson set the point value for this task to 2.Jan 30 2018, 5:35 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog-Archived board.Jan 30 2018, 7:33 PM

Jdlrobson moved this task from Backlog to Bugs on the MinervaNeue board.Jan 31 2018, 10:46 PM

ovasileva triaged this task as High priority.Feb 6 2018, 5:15 PM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.

Jdlrobson moved this task from Upcoming to 2017-18 Q3 on the Web-Team-Backlog-Archived board.Feb 6 2018, 5:32 PM

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Feb 7 2018, 6:16 PM

Jdlrobson moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.Feb 7 2018, 6:55 PM

Jdlrobson updated the task description. (Show Details)Feb 7 2018, 10:42 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.

Change 409097 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Pages that do not exist cannot have issues

https://gerrit.wikimedia.org/r/409097

gerritbot added a project: Patch-For-Review.Feb 8 2018, 6:14 PM

Jdlrobson updated the task description. (Show Details)Feb 8 2018, 8:43 PM

pmiazga mentioned this in T186829: MobileFrontend mobile.init loadCurrentPage function doesn't pass `isMissing` property.Feb 8 2018, 9:13 PM

Change 409097 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Pages that do not exist cannot have issues

https://gerrit.wikimedia.org/r/409097

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 10 2018, 10:00 AM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Feb 13 2018, 6:05 PM

Over to you Anthony

LGTM

Screen Shot 2018-02-16 at 10.32.33 AM.png (1×2 px, 774 KB)

ovasileva closed this task as Resolved.Feb 19 2018, 10:44 AM

	F13807154: Screen Shot 2018-02-16 at 10.32.33 AM.png
	Feb 16 2018, 6:33 PM

	F12669488: Screenshot_20180119-171224.png
	Jan 20 2018, 12:16 AM

	F12669476: Screenshot_20180119-170904.png
	Jan 20 2018, 12:16 AM

Regression: Non-existent articles appear blank on mobile EN wikipediaClosed, ResolvedPublic2 Estimated Story PointsActions