Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Convert AutoProxyBlock to use extension registration | mediawiki/extensions/AutoProxyBlock | master | +565 -102 |
Details
Status | Subtype | Assigned | Task | |
---|---|---|---|---|
· · · | ||||
Open | Goal | None | T98668 Convert all extensions and skins on gerrit to use extension registration | |
Resolved | MarcoAurelio | T185384 Convert AutoProxyBlock to use extension registration | ||
Resolved | Mainframe98 | T185652 AutoProxyBlock uses unserialization on externally obtained php code | ||
· · · |
Event Timeline
Change 405409 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/AutoProxyBlock@master] Convert AutoProxyBlock to use extension registration
Note: I had to set $wgAutoProxyBlockLog in AutoProxyBlock.php to true in order to get the complete output on extension.json. That said, I'm not sure if this extension even works as it's currently coded. It has no active maintainer. The install script looks kinda obsolete. Wondering if we should be archiving this instead.
@Mainframe98 I changed https://gerrit.wikimedia.org/r/#/c/405409/5..7/extension.json so it does not enable the log thing by default. Is that okay?
That matches the previous configuration, so that should be okay.
It still leaves the point that pre-extension registration, the log would not exist to MediaWiki at all, while now the log always exists. Considering how many extensions do the same, I think it should be fine though. I'll +1 when T185652 is merged.
@Bawolff @Jdforrester-WMF @Legoktm Could you please review (and merge if it is okay) https://gerrit.wikimedia.org/r/#/c/405409/ ? Thanks.
Change 405409 merged by jenkins-bot:
[mediawiki/extensions/AutoProxyBlock@master] Convert AutoProxyBlock to use extension registration