Page MenuHomePhabricator

SurfaceSynchronizer: outdated author selections can leak
Closed, ResolvedPublic8 Story Points

Description

Steps to reproduce:

  1. Edit a rebaser document containing 'AB'
  2. Select and italicize 'AB'
  3. Simultaneously, cursor between A and B and press Enter twice

Expected behaviour: 'AB' is italicized

Observed behaviour: Exception due to painting outdated author selection

Bisecting shows this bug has been present since 78c7beecbf806133484ba4a9e31f1cf70da34fd1 .

Event Timeline

dchan created this task.Jan 20 2018, 8:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2018, 8:07 PM

Change 405546 had a related patch set uploaded (by Catrope; owner: Catrope):
[VisualEditor/VisualEditor@master] SurfaceSynchronizer: Clear author selections when unapplying

https://gerrit.wikimedia.org/r/405546

Change 405546 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] SurfaceSynchronizer: Clear author selections when unapplying

https://gerrit.wikimedia.org/r/405546

Change 405549 had a related patch set uploaded (by Catrope; owner: Catrope):
[VisualEditor/VisualEditor@master] SurfaceSynchronizer: Translate selections when unapplying

https://gerrit.wikimedia.org/r/405549

Change 405549 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] SurfaceSynchronizer: Translate selections when unapplying

https://gerrit.wikimedia.org/r/405549

Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF assigned this task to Catrope.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Fixed?

Jdforrester-WMF triaged this task as Normal priority.Jan 20 2018, 10:19 PM

Change 404763 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (982919680)

https://gerrit.wikimedia.org/r/404763

Change 404763 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (88ba1eb9a)

https://gerrit.wikimedia.org/r/404763

Jdforrester-WMF closed this task as Resolved.Jan 29 2018, 5:19 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 29 2018, 5:19 PM