Page MenuHomePhabricator
Create Task
Maniphest T185395

SurfaceSynchronizer: outdated author selections can leak
Closed, ResolvedPublic8 Story Points
Actions

Description

Steps to reproduce:

  1. Edit a rebaser document containing 'AB'
  2. Select and italicize 'AB'
  3. Simultaneously, cursor between A and B and press Enter twice

Expected behaviour: 'AB' is italicized

Observed behaviour: Exception due to painting outdated author selection

Bisecting shows this bug has been present since 78c7beecbf806133484ba4a9e31f1cf70da34fd1 .

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterUpdate VE core submodule to master (88ba1eb9a)
VisualEditor/VisualEditor : masterSurfaceSynchronizer: Translate selections when unapplying
VisualEditor/VisualEditor : masterSurfaceSynchronizer: Clear author selections when unapplying

Related Objects

Event Timeline

dchan created this task.Jan 20 2018, 8:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2018, 8:07 PM
gerritbot added a subscriber: gerritbot.Jan 20 2018, 9:19 PM

Change 405546 had a related patch set uploaded (by Catrope; owner: Catrope):
[VisualEditor/VisualEditor@master] SurfaceSynchronizer: Clear author selections when unapplying

https://gerrit.wikimedia.org/r/405546

gerritbot added a comment.Jan 20 2018, 9:29 PM

Change 405546 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] SurfaceSynchronizer: Clear author selections when unapplying

https://gerrit.wikimedia.org/r/405546

gerritbot added a comment.Jan 20 2018, 9:58 PM

Change 405549 had a related patch set uploaded (by Catrope; owner: Catrope):
[VisualEditor/VisualEditor@master] SurfaceSynchronizer: Translate selections when unapplying

https://gerrit.wikimedia.org/r/405549

gerritbot added a comment.Jan 20 2018, 10:14 PM

Change 405549 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] SurfaceSynchronizer: Translate selections when unapplying

https://gerrit.wikimedia.org/r/405549

Jdforrester-WMF assigned this task to Catrope.Jan 20 2018, 10:19 PM
Jdforrester-WMF moved this task from To Triage to TR3: Language support on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 8.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Fixed?

Jdforrester-WMF triaged this task as Medium priority.Jan 20 2018, 10:19 PM
gerritbot added a comment.Jan 20 2018, 10:27 PM

Change 404763 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (982919680)

https://gerrit.wikimedia.org/r/404763

gerritbot added a comment.Jan 22 2018, 4:43 AM

Change 404763 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (88ba1eb9a)

https://gerrit.wikimedia.org/r/404763

Jdforrester-WMF closed this task as Resolved.Jan 29 2018, 5:19 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 29 2018, 5:19 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL