Hello, I've made required changes here: https://www.mediawiki.org/wiki/Best_practices_for_extensions#Database.

I'm not sure if it's enough or do I need to make changes elsewhere as well?
Do let me know!
Thank you!

In T185426#5045927, @Eisheeta wrote:

Hello, I've made required changes here: https://www.mediawiki.org/wiki/Best_practices_for_extensions#Database.

I'm not sure if it's enough or do I need to make changes elsewhere as well?
Do let me know!
Thank you!

I note there's a few usages of "SHALL NOT" on this page, but that's not a defined term (out of the scope of this task though).

I did word the task to say "should", I wonder if "RECOMMENDED" is more appropriate for that page

(wording and english is hard!)

Per the original description..

https://www.mediawiki.org/wiki/Manual:Developing_extensions#Adding_database_tables - Should mention here that extensions should not modify core tables, but add their own, with a FK to the relevant MW table

Either in https://www.mediawiki.org/wiki/Manual:Hooks/LoadExtensionSchemaUpdates#Usage or https://www.mediawiki.org/wiki/Manual:Hooks/LoadExtensionSchemaUpdates#Summary I think it's a good place to reiterate the above too, because this is likely where developers new to MW might be looking to know how to make database changes, so having it highlighted would be a good idea (that page maybe needs some of the older methods removing too)

How is your sql? I wonder if we could add a really simple example too

I don't think, offhand at least, the other pages necessarily need this information

@Reedy Thank you so much for your feedback. :) I think should should suffice at this point if we're not sure of the impact of the extension modifying the core table. Also, I'll update the pages you've mentioned as well!

I do know basic sql, but it'd be great if you could let me know what kind of an example and where should we include it?