Page MenuHomePhabricator

[Bug] Lexeme diffs fail because of incomplete Form diffing [M]
Closed, ResolvedPublic

Description

Forms can not only change, Forms can also be added and removed. This is currently not covered by the code in LexemeDiffer::getFormsDiff. This code only covers changes, but neither additions nor removals.

This issue becomes visible right now when comparing two different Lexemes via an URL like …?oldid=…&diff=… with two revision IDs from two different Lexemes. This is a quite typical use case, e.g. if two entities are duplicates and the user wants to compare the two. Currently this diff fails hard with quite extreme exceptions complaining about objects where strings are expected.

Example: http://wikidata-lexeme.wmflabs.org/index.php?title=Lexeme:L13&diff=20952&oldid=58

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseLexeme : masterFix incomplete Form diffing not covering adding/removal of Forms

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2018, 12:19 PM

Change 405697 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fix incomplete Form diffing not covering adding/removal of Forms

https://gerrit.wikimedia.org/r/405697

thiemowmde triaged this task as Normal priority.Jan 22 2018, 12:20 PM
thiemowmde moved this task from incoming to consider for next sprint on the Wikidata board.
thiemowmde renamed this task from [Bug] Cross-entity diffs fail because of incomplete Form diffing to [Bug] Lexeme diffs fail because of incomplete Form diffing.Jan 30 2018, 2:14 PM
thiemowmde updated the task description. (Show Details)
WMDE-leszek renamed this task from [Bug] Lexeme diffs fail because of incomplete Form diffing to [Bug] Lexeme diffs fail because of incomplete Form diffing [M].Jan 30 2018, 2:18 PM
WMDE-leszek raised the priority of this task from Normal to High.Jan 30 2018, 2:31 PM

Change 405697 abandoned by Thiemo Kreuz (WMDE):
Fix incomplete Form diffing not covering adding/removal of Forms

https://gerrit.wikimedia.org/r/405697