[Bug] Lexeme diffs fail because of incomplete Form diffing [M]
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	thiemowmde
	Jan 22 2018, 12:19 PM

Description

Forms can not only change, Forms can also be added and removed. This is currently not covered by the code in LexemeDiffer::getFormsDiff. This code only covers changes, but neither additions nor removals.

This issue becomes visible right now when comparing two different Lexemes via an URL like …?oldid=…&diff=… with two revision IDs from two different Lexemes. This is a quite typical use case, e.g. if two entities are duplicates and the user wants to compare the two. Currently this diff fails hard with quite extreme exceptions complaining about objects where strings are expected.

Example: http://wikidata-lexeme.wmflabs.org/index.php?title=Lexeme:L13&diff=20952&oldid=58

Details

	Subject	Repo	Branch	Lines +/-
	Fix incomplete Form diffing not covering adding/removal of Forms	mediawiki/extensions/WikibaseLexeme	master	+74 -29

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Tarrow	T185481 [Bug] Unexpected order of Lexeme DataModel elements in complex diffs
Resolved	None	T185477 [Bug] Lexeme diffs fail because of incomplete Form diffing [M]
Resolved	None	T186317 Handle adding and/or removing forms in lexeme diffs

Event Timeline

thiemowmde created this task.Jan 22 2018, 12:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2018, 12:19 PM

Change 405697 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Fix incomplete Form diffing not covering adding/removal of Forms

https://gerrit.wikimedia.org/r/405697

gerritbot added a project: Patch-For-Review.Jan 22 2018, 12:19 PM

thiemowmde triaged this task as Medium priority.Jan 22 2018, 12:20 PM

thiemowmde moved this task from incoming to consider for next sprint on the Wikidata board.

thiemowmde mentioned this in rEWLE8077e160e7fa: Fix incomplete Form diffing not covering adding/removal of Forms.Jan 22 2018, 12:21 PM

thiemowmde added a parent task: T185481: [Bug] Unexpected order of Lexeme DataModel elements in complex diffs.Jan 22 2018, 12:33 PM

thiemowmde renamed this task from [Bug] Cross-entity diffs fail because of incomplete Form diffing to [Bug] Lexeme diffs fail because of incomplete Form diffing.Jan 30 2018, 2:14 PM

thiemowmde updated the task description. (Show Details)

WMDE-leszek renamed this task from [Bug] Lexeme diffs fail because of incomplete Form diffing to [Bug] Lexeme diffs fail because of incomplete Form diffing [M].Jan 30 2018, 2:18 PM

Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Jan 30 2018, 2:21 PM

WMDE-leszek added a project: Wikidata-Sprint-2018-01-31.Jan 30 2018, 2:21 PM

WMDE-leszek raised the priority of this task from Medium to High.Jan 30 2018, 2:31 PM

thiemowmde mentioned this in rEWLE70b16d22e197: Fix incomplete Form diffing not covering adding/removal of Forms.Feb 2 2018, 4:13 PM

thiemowmde mentioned this in rEWLE3e4395c1dc6a: Fix incomplete Form diffing not covering adding/removal of Forms.Feb 2 2018, 5:39 PM

WMDE-leszek removed projects: Patch-For-Review, Technical-Debt.Feb 5 2018, 10:43 AM

thiemowmde mentioned this in rEWLE5bd6d0848b53: Fix incomplete Form diffing not covering adding/removal of Forms.Feb 5 2018, 10:54 AM

WMDE-leszek moved this task from Backlog to Done on the Wikidata-Sprint-2018-01-31 board.Feb 8 2018, 9:50 AM

Lydia_Pintscher closed this task as Resolved.Feb 13 2018, 1:20 PM

Lydia_Pintscher closed subtask T186317: Handle adding and/or removing forms in lexeme diffs as Resolved.

Change 405697 abandoned by Thiemo Kreuz (WMDE):
Fix incomplete Form diffing not covering adding/removal of Forms

https://gerrit.wikimedia.org/r/405697