Page MenuHomePhabricator

[Bug] Unexpected order of Lexeme DataModel elements in complex diffs
Closed, ResolvedPublic3 Estimated Story Points


The order of elements in more complex diffs is not consistent with the order of elements in the formal datamodel as specified in This is visible when comparing two revisions with lots of edits in between, or when comparing two revisions from two different Lexemes.


The Lexemes statements are first, followed by "Lemma" and "lexical category". It should be the other way around, statements last.

image.png (381×354 px, 18 KB)

GIVEN an edit on a Lemma of a Lexeme
AND an edit on a statement on a Lexeme
WHEN viewing a diff that includes those edits
THEN the edits on the Lemma show up first in the diff

Acceptance criteria:

  • the order of diff elements reflects the order on the Lexeme page (Lemma -> Language -> Lexical category -> Lexeme statements)

Event Timeline

Addshore added a subscriber: Addshore.

I don't think this is really technical debt, just a bug / feature not considered when defining requirements, so removing the tag

WMDE-leszek set the point value for this task to 3.Aug 7 2018, 12:33 PM

Change 462685 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] Fix Lexeme Diff Order

Change 462685 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix Lexeme Diff Order