Page MenuHomePhabricator

Convert CategorySortHeaders to use extension registration
Closed, ResolvedPublic

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

Jayprakash12345 created this task.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 405701 had a related patch set uploaded (by Jayprakash12345; owner: Jayprakash12345):
[mediawiki/extensions/CategorySortHeaders@master] Convert CategorySortHeaders to use extension reg

https://gerrit.wikimedia.org/r/405701

@Jayprakash12345 Hi. Could you see some comments left in the patch by Brian Wolff and Umherirrender?

@Bawolff Is the commit message for that patch good now?

Change 405701 abandoned by Jayprakash12345:
Convert CategorySortHeaders to use extension registration

Reason:
Patch will be broke the extension, so it will good to left the extension alone.

https://gerrit.wikimedia.org/r/405701

Jayprakash12345 removed Jayprakash12345 as the assignee of this task.

All i said is it should document that its making a breaking change. Or maybe it should use an extension callback to keep the old behaviour. Regardless it doesnt mean the bug is WONTFIX only that the patch was wrong.

Change 405701 restored by Jayprakash12345:
Convert CategorySortHeaders to use extension registration

https://gerrit.wikimedia.org/r/405701

Change 680361 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/extensions/CategorySortHeaders@master] [CategorySortHeaders] Cleanup and convert to ExtensionRegistry

https://gerrit.wikimedia.org/r/680361

Change 681370 had a related patch set uploaded (by Universal Omega; author: Universal Omega):

[mediawiki/extensions/CategorySortHeaders@REL1_36] [CategorySortHeaders] Cleanup and convert to ExtensionRegistry

https://gerrit.wikimedia.org/r/681370

Change 681370 merged by jenkins-bot:

[mediawiki/extensions/CategorySortHeaders@REL1_36] [CategorySortHeaders] Cleanup and convert to ExtensionRegistry

https://gerrit.wikimedia.org/r/681370

Change 680361 merged by jenkins-bot:

[mediawiki/extensions/CategorySortHeaders@master] [CategorySortHeaders] Cleanup and convert to ExtensionRegistry

https://gerrit.wikimedia.org/r/680361

Change 405701 abandoned by Jack Phoenix:

[mediawiki/extensions/CategorySortHeaders@master] Convert CategorySortHeaders to use extension registration

Reason:

Obsolete patch, a similar one was already merged

https://gerrit.wikimedia.org/r/405701