[BUG] Featured article shows as 'SAVED' after article is removed from reading lists
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Jan 22 2018, 4:08 PM

Description

Steps to reproduce

Open the Explore feed and tap on the "Save" action on a Featured article card to save it to a reading list
Navigate to the reading list and delete it from that list
Return to the Explore feed

Expected

The 'Save' action on the featured article should revert to "Save" since it is no longer saved to a reading list.

Actual

The featured article still shows as "Saved"

Occurring on

Moto X (5.0) on Wikipedia v2.7.224-alpha-2018-01-19

Details

	Subject	Repo	Branch	Lines +/-
	Follow-up to 'SAVED' button fill state.	apps/android/wikipedia	master	+45 -50
	Fix: Featured article shows as 'SAVED' after article is removed from reading lists	apps/android/wikipedia	master	+50 -0

Customize query in gerrit

Event Timeline

RHo created this task.Jan 22 2018, 4:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2018, 4:08 PM

• Charlotte triaged this task as Medium priority.Jan 29 2018, 5:17 PM

• Charlotte moved this task from Needs Triage to Android-app-release-v2.7.23x-G-Grape on the Wikipedia-Android-App-Backlog board.

• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape); removed Wikipedia-Android-App-Backlog.

Restricted Application edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape). · View Herald TranscriptJan 29 2018, 5:17 PM

Sharvaniharan claimed this task.Jan 29 2018, 6:05 PM

Sharvaniharan moved this task from Needs Triage to Android-app-release-v2.7.23x-G-Grape on the Wikipedia-Android-App-Backlog board.

Sharvaniharan edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape); removed Wikipedia-Android-App-Backlog.

Change 406771 had a related patch set uploaded (by Sharvaniharan; owner: Sharvaniharan):
[apps/android/wikipedia@master] Fix: Featured article shows as 'SAVED' after article is removed from reading lists

https://gerrit.wikimedia.org/r/406771

gerritbot added a project: Patch-For-Review.Jan 29 2018, 10:04 PM

Sharvaniharan moved this task from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape) board.Jan 30 2018, 2:14 PM

Change 413739 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Follow-up to 'SAVED' button fill state.

https://gerrit.wikimedia.org/r/413739

Change 406771 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Featured article shows as 'SAVED' after article is removed from reading lists

https://gerrit.wikimedia.org/r/406771

Change 413739 merged by jenkins-bot:
[apps/android/wikipedia@master] Follow-up to 'SAVED' button fill state.

https://gerrit.wikimedia.org/r/413739

Dbrant moved this task from Code Review to Design Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape) board.Feb 27 2018, 10:06 PM

Works for me on Nexus 5, testing v2.7.225-alpha-2018-03-02

Looks good to me on 2.7.226-alpha-2018-03-06

Dbrant closed this task as Resolved.Mar 14 2018, 5:03 PM

[BUG] Featured article shows as 'SAVED' after article is removed from reading listsClosed, ResolvedPublicActions