Page MenuHomePhabricator

Pasting from LibreOffice calc corrupts page styles
Closed, ResolvedPublic1 Story Points

Description

It appears a <style> tag is in the clipboard, and gets appended to ceSurface.$pasteTarget. Looks like we need to directly sanitize the pasteTarget.

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterUpdate VE core submodule to master (c5fddd508)
VisualEditor/VisualEditor : masterRemove <style> tags from pasteTarget ASAP

Event Timeline

Esanders created this task.Jan 22 2018, 9:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2018, 9:12 PM

Change 405809 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Remove <style> tags from pasteTarget ASAP

https://gerrit.wikimedia.org/r/405809

Deskana triaged this task as Medium priority.Jan 22 2018, 10:18 PM
Deskana set the point value for this task to 1.
Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.

Change 405809 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Remove <style> tags from pasteTarget ASAP

https://gerrit.wikimedia.org/r/405809

Change 405751 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

Change 405751 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

Jdforrester-WMF closed this task as Resolved.Jan 29 2018, 5:12 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 29 2018, 5:12 PM