Page MenuHomePhabricator
Create Task
Maniphest T185532

Pasting from LibreOffice calc corrupts page styles
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

It appears a <style> tag is in the clipboard, and gets appended to ceSurface.$pasteTarget. Looks like we need to directly sanitize the pasteTarget.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (c5fddd508)mediawiki/extensions/VisualEditormaster+40 -15
Remove <style> tags from pasteTarget ASAPVisualEditor/VisualEditormaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jan 22 2018, 9:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2018, 9:12 PM
gerritbot subscribed.Jan 22 2018, 10:15 PM

Change 405809 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Remove <style> tags from pasteTarget ASAP

https://gerrit.wikimedia.org/r/405809

gerritbot added a project: Patch-For-Review.Jan 22 2018, 10:15 PM
• Deskana triaged this task as Medium priority.Jan 22 2018, 10:18 PM
• Deskana set the point value for this task to 1.
• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
gerritbot added a comment.Jan 22 2018, 10:22 PM

Change 405809 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Remove <style> tags from pasteTarget ASAP

https://gerrit.wikimedia.org/r/405809

gerritbot added a comment.Jan 27 2018, 2:21 AM

Change 405751 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

gerritbot added a comment.Jan 29 2018, 4:57 PM

Change 405751 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

Jdforrester-WMF closed this task as Resolved.Jan 29 2018, 5:12 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 29 2018, 5:12 PM
Jdforrester-WMF added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 29 2018, 5:17 PM
matmarex mentioned this in T226374: Impossible to copypaste a specific template across windows.Jul 16 2019, 8:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits