Page MenuHomePhabricator
Create Task
Maniphest T185544

Inspectors inside surface widgets have broken layouts
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Open Citoid or the link inspector from inside the media dialog:

image.png (670×714 px, 58 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+1 -1Update VE core submodule to master (c39a4a69b)
VisualEditor/VisualEditormaster+0 -6Revert "Workaround missing child selector in OOUI for menuLayout"
mediawiki/extensions/VisualEditormaster+40 -15Update VE core submodule to master (c5fddd508)
VisualEditor/VisualEditormaster+6 -0Workaround missing child selector in OOUI for menuLayout
oojs/uimaster+13 -12Use child selectors for menuLayout
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jan 22 2018, 10:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2018, 10:59 PM
gerritbot added a subscriber: gerritbot.Jan 22 2018, 11:00 PM

Change 405814 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Workaround missing child selector in OOUI for menuLayout

https://gerrit.wikimedia.org/r/405814

gerritbot added a project: Patch-For-Review.Jan 22 2018, 11:00 PM
gerritbot added a comment.Jan 22 2018, 11:08 PM

Change 405815 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Use child selectors for menuLayout

https://gerrit.wikimedia.org/r/405815

gerritbot added a comment.Jan 22 2018, 11:44 PM

Change 405814 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Workaround missing child selector in OOUI for menuLayout

https://gerrit.wikimedia.org/r/405814

Deskana triaged this task as Medium priority.Jan 22 2018, 11:54 PM
Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
Deskana set the point value for this task to 1.
gerritbot added a comment.Jan 23 2018, 12:22 AM

Change 405815 merged by jenkins-bot:
[oojs/ui@master] Use child selectors for menuLayout

https://gerrit.wikimedia.org/r/405815

gerritbot added a comment.Jan 23 2018, 1:14 AM

Change 405829 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Revert "Workaround missing child selector in OOUI for menuLayout"

https://gerrit.wikimedia.org/r/405829

gerritbot added a comment.Jan 27 2018, 2:21 AM

Change 405751 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

gerritbot added a comment.Jan 29 2018, 4:57 PM

Change 405751 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

Jdforrester-WMF closed this task as Resolved.Jan 29 2018, 5:13 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF moved this task from Backlog to OOUI-0.25.2 on the OOUI board.
Jdforrester-WMF edited projects, added OOUI (OOUI-0.25.2); removed OOUI.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 29 2018, 5:13 PM
Jdforrester-WMF added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 29 2018, 5:17 PM
Ryasmeen added a project: Verified.Feb 2 2018, 7:23 PM
Ryasmeen merged a task: T178986: Link and citation dialogues stretching vertically inside media caption.Feb 2 2018, 7:33 PM
Ryasmeen added subscribers: Deskana, Ryasmeen, Whatamidoing-WMF.
gerritbot added a comment.Feb 11 2018, 2:40 AM

Change 409632 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c39a4a69b)

https://gerrit.wikimedia.org/r/409632

gerritbot added a project: Patch-For-Review.Feb 11 2018, 2:40 AM
gerritbot added a comment.Feb 12 2018, 5:39 PM

Change 409632 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c39a4a69b)

https://gerrit.wikimedia.org/r/409632

Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Mar 19 2018, 10:15 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL