Page MenuHomePhabricator

Inspectors inside surface widgets have broken layouts
Closed, ResolvedPublic1 Story Points

Description

Open Citoid or the link inspector from inside the media dialog:

Details

Related Gerrit Patches:
mediawiki/extensions/VisualEditor : masterUpdate VE core submodule to master (c39a4a69b)
VisualEditor/VisualEditor : masterRevert "Workaround missing child selector in OOUI for menuLayout"
mediawiki/extensions/VisualEditor : masterUpdate VE core submodule to master (c5fddd508)
VisualEditor/VisualEditor : masterWorkaround missing child selector in OOUI for menuLayout
oojs/ui : masterUse child selectors for menuLayout

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2018, 10:59 PM

Change 405814 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Workaround missing child selector in OOUI for menuLayout

https://gerrit.wikimedia.org/r/405814

Change 405815 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] Use child selectors for menuLayout

https://gerrit.wikimedia.org/r/405815

Change 405814 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Workaround missing child selector in OOUI for menuLayout

https://gerrit.wikimedia.org/r/405814

Deskana triaged this task as Medium priority.Jan 22 2018, 11:54 PM
Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
Deskana set the point value for this task to 1.

Change 405815 merged by jenkins-bot:
[oojs/ui@master] Use child selectors for menuLayout

https://gerrit.wikimedia.org/r/405815

Change 405829 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] Revert "Workaround missing child selector in OOUI for menuLayout"

https://gerrit.wikimedia.org/r/405829

Change 405751 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

Change 405751 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

Jdforrester-WMF closed this task as Resolved.Jan 29 2018, 5:13 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF moved this task from Backlog to OOUI-0.25.2 on the OOUI board.
Jdforrester-WMF edited projects, added OOUI (OOUI-0.25.2); removed OOUI.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 29 2018, 5:13 PM

Change 409632 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c39a4a69b)

https://gerrit.wikimedia.org/r/409632

Change 409632 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c39a4a69b)

https://gerrit.wikimedia.org/r/409632