Page MenuHomePhabricator

+2 for WMDE-leszek in mediawiki/*
Closed, ResolvedPublic

Assigned To
Authored By
Addshore
Jan 23 2018, 6:34 PM
Referenced Files
None
Tokens
"Meh!" token, awarded by MichaelSchoenitzer_WMDE."Like" token, awarded by Johan."Love" token, awarded by gabriel-wmde."Love" token, awarded by JStrodt_WMDE."Meh!" token, awarded by Bmueller."Love" token, awarded by Lydia_Pintscher."Like" token, awarded by Jdforrester-WMF."Love" token, awarded by Kizule."Love" token, awarded by WMDE-Fisch."Like" token, awarded by Ladsgroup.

Description

I would like to nominate WMDE-leszek for +2 in mediawiki/ repositories.

Code reviews: https://gerrit.wikimedia.org/r/#/q/label:Code-Review%252Cuser%253DWMDE-leszek
Merged patches: https://gerrit.wikimedia.org/r/#/q/owner:%22WMDE-leszek+%253Cleszek.manicki%2540wikimedia.de%253E%22+status:merged

Leszek has been working with mediawiki since 2016, has worked on mediawiki features and extensions that are deployed to all / most WMF projects, including RevisionSlider and Wikibase. He has worked on refactorings in core (mainly around Watched items). I have no doubts.

Event Timeline

If even _I_ have +2 there @WMDE-leszek should goat it as well!

goat-for-it

I'm not sure how I feel. Leszek certainly has a lot of contributions to many extensions, and seems to be a good programmer. But I would normally want more contributions to MediaWiki core before +2 to core. (This should not be counted as a negative vote, I just need to think some about it)

I'm not sure how I feel. Leszek certainly has a lot of contributions to many extensions, and seems to be a good programmer. But I would normally want more contributions to MediaWiki core before +2 to core. (This should not be counted as a negative vote, I just need to think some about it)

You know what, he's very clearly very active on many extensions, and clearly knows what he is doing, and +2 is not just for MW core. I vote support.

But I would normally want more contributions to MediaWiki core before +2 to core.

I trust leszek isn't going to merge anything that he doesn't feel comfortable with merging.

I often like to point out that all wmf employees (afaik) can techncially merge in mediawiki and all extensions, even when they have no contributions to core or any extensions.
Why would we trust them more than we trust wmde employees that have actually worked with mediawiki? ;)

Leszek has been working with mediawiki since 2016, has worked on mediawiki features and extensions that are deployed to all / most WMF projects, including RevisionSlider and Wikibase. He has worked on refactorings in core (mainly around Watched items). I have no doubts.

I often like to point out that all wmf employees (afaik) can techncially merge in mediawiki and all extensions, even when they have no contributions to core or any extensions.

Yeah, and I think that's terrible, but that's a different discussion.

I'm not sure how I feel. Leszek certainly has a lot of contributions to many extensions, and seems to be a good programmer. But I would normally want more contributions to MediaWiki core before +2 to core. (This should not be counted as a negative vote, I just need to think some about it)

I understand your concerns but let me add another point of view: Working with a very complex core extension called Wikibase requires lots of knowledge of the core itself. His knowledge of the core, as his teammate who interacts with him on everyday basis, keeps me fascinated and wonder why he doesn't have +2 rights already.

Give him merge rights. I support this.

Legoktm claimed this task.

Done!