Page MenuHomePhabricator

Assign additional owner to the Variables extension
Closed, ResolvedPublic

Description

This quite simple patch (T173625) has been waiting for merging for months, and it's still pending. The code has been reviewed multiple times and I doubt there are any major flaws left. However, @Danwe, single owner of the extension, is quite inactive and didn't react in any way since the patch was uploaded in August.

What's the path to choose here to get the patch finally merged?

Event Timeline

What's the path to choose here to get the patch finally merged?

Squeaky wheel gets the oil. You just have to be really squeaky. Patch is merged now.

For the broader question of giving someone +2 - its possible if someone else is interested and the original author has abandoned it. Probably just requires discussion and agreement (Among who is agreement required is the hard part).

What's the path to choose here to get the patch finally merged?

Squeaky wheel gets the oil. You just have to be really squeaky. Patch is merged now.

Thank you very much!

For the broader question of giving someone +2 - its possible if someone else is interested and the original author has abandoned it. Probably just requires discussion and agreement (Among who is agreement required is the hard part).

I'm unsure if this is necessary in the moment, but we have to keep in mind use of the Variables extension is quite common among third-party wikis. I think it's desirable to have some active maintenance in place here, that can act quickly if stuff breaks.

@MGChecker: Do you have somebody in mind who would be interested in becoming co-maintainer?

https://www.mediawiki.org/wiki/Gerrit/Code_review/Getting_reviews#No_timely_feedback comes to my mind (might welcome edits).

Kghbln triaged this task as Medium priority.Jan 24 2018, 5:01 PM

I support @MGChecker getting +2 for the repo. He is right. It is quite an important extension.

Yeah, just give @MGChecker or someone else the rights.

I still can't sign into Gerrit with my existing account and I think the last time I tried to get support it didn't help much. If the repos were on GitHub I'd be up for a review at any time but dealing with Gerrit just takes too much of my time really.

I can do it, if you want me to, and I think I will be able to handle the rights. Particularly, I'm aware of the responsibility that comes with +2 access. Nevertheless I want to point out that my knowledge in the field of MediaWiki extensions is limited. There are many people who are far more competent for this job than me.

Legoktm claimed this task.

Apologies for letting this sit for nearly a month. Per T185595#3926811 I've added @MGChecker as an owner of the extension.