Page MenuHomePhabricator
Create Task
Maniphest T185632

No trailing newline in temporary wikitext editor
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In source mode, a trailing newline gets appended to the content. (T156609) As far as I can tell (well, the editor actually loads faster then I can edit), this trailing newline is missing while the temporary wikitext editor is active. It should be present even then.

Details

SubjectRepoBranchLines +/-
Add trailing linebreak to NWE's temporary wikitext editormediawiki/extensions/VisualEditormaster+12 -1
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Jan 24 2018, 10:18 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 24 2018, 10:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Feb 1 2018, 8:25 PM

Change 407499 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Add trailing linebreak in NWE

https://gerrit.wikimedia.org/r/407499

gerritbot added a project: Patch-For-Review.Feb 1 2018, 8:25 PM
gerritbot added a comment.Feb 7 2018, 12:06 AM

Change 407499 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add trailing linebreak to NWE's temporary wikitext editor

https://gerrit.wikimedia.org/r/407499

Jdforrester-WMF closed this task as Resolved.Feb 7 2018, 12:40 AM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF removed a project: Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 7 2018, 12:40 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 7 2018, 1:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL