Page MenuHomePhabricator

Do not use mentioning user’s interface language in mention emails
Open, Needs TriagePublic

Description

I got an email about this edit with the text Erledigt Tacsipacsi Awesome! Thank you! (I use plain text emails). I suppose it says “Erledigt” because @Perhelion uses German interface language. The on-wiki notification uses Hungarian text, as my interface language is Hungarian. So I think the email should also use my interface language, but if not, then the site default, and certainly not the mentioning user’s one, because doing so leaks an otherwise private preference of the user.


The issue is reproducible on commons beta(it seems to be commons wiki specific):

  • user A changes user interface to German
  • user A adds {{done}} {{U|User B}} (the edit in the ticket description) to any Talk page. Immediately {{done}} will be displayed as 'Erledigt' (even before saving the edit).

Screen Shot 2024-01-26 at 5.25.35 PM.png (2,156×666 px, 143 KB)

  • user B has English UI and receives the notification in English:

Screen Shot 2024-01-26 at 5.35.14 PM.png (1,048×376 px, 61 KB)

But an email will have 'Erledigt' - the reported issue is confirmed.
Screen Shot 2024-01-26 at 5.14.22 PM.png (1,976×982 px, 142 KB)

To summarize:

  • the issue is specific to commonswiki (since it's a multi-language wiki)
  • the issue is present only in emails
  • notifications/emails from lang wikis will display {{done}} template as Done disregarding the UI lang of a sender or of a receiver which is a correct behavior.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Etonkovidova - Is this something you could test to verify it's reproducible?
It seems like a serious issue, but the task was originally logged in 2018, so I want to verify if it's still an issue. Thank you!

@Etonkovidova - Is this something you could test to verify it's reproducible?
It seems like a serious issue, but the task was originally logged in 2018, so I want to verify if it's still an issue. Thank you!

@KStoller-WMF The issue is reproducible on commons beta(it seems to be commons wiki specific):

  • user A changes user interface to German
  • user A adds {{done}} {{U|User B}} (the edit in the ticket description) to any Talk page. Immediately {{done}} will be displayed as 'Erledigt' (even before saving the edit).

Screen Shot 2024-01-26 at 5.25.35 PM.png (2,156×666 px, 143 KB)

  • user B has English UI and receives the notification in English:

Screen Shot 2024-01-26 at 5.35.14 PM.png (1,048×376 px, 61 KB)

But an email will have 'Erledigt' - the reported issue is confirmed.
Screen Shot 2024-01-26 at 5.14.22 PM.png (1,976×982 px, 142 KB)

To summarize:

  • the issue is specific to commonswiki (since it's a multi-language wiki)
  • the issue is present only in emails
  • notifications/emails from lang wikis will display {{done}} template as Done disregarding the UI lang of a sender or of a receiver which is a correct behavior.

Thank you, @Etonkovidova for the thorough explanation!

I'll chat with the language team and move this to Triaged for Growth.