After T178079: Implement a (conservative) usage aspect deduplicater (days: 4) being done it's needed to implement a deduplicator that turn too many usecases of on aspect with modifier to the aspect without modifier. This is helpful in case the lua function is iterating over all languages or properties. For example:
The threshold for C, D, and L aspects need to be determined before moving forward.
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Resolved | Lydia_Pintscher | T49288 [Epic] Track Wikidata entity usage on client pages | ||
| Resolved | Ladsgroup | T185693 Implement a (more liberal) usage aspect deduplicater (days: 3) | ||
| · · · |
Change 406181 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Turn to a general aspect if too many modifiers have been used
I think we need different limits for different aspects. 10 may be sensible for statements, but it's way too low for languages.
Was looking on cawiki_p to see it in the real world:
Change 406809 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Do not re-instantiate UsageDeduplicator every time
Change 406181 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Turn to a general aspect if too many modifiers have been used
Change 406809 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Do not re-instantiate UsageDeduplicator every time
Change 408528 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/mediawiki-config@master] Add entityUsageModifierLimits config for Wikibase
Change 408528 merged by jenkins-bot:
[operations/mediawiki-config@master] Add entityUsageModifierLimits config for Wikibase
Mentioned in SAL (#wikimedia-operations) [2018-02-06T14:10:10Z] <ladsgroup@tin> Synchronized wmf-config/Wikibase.php: [[gerrit:408528|Add entityUsageModifierLimits config for Wikibase (T185693)]] (duration: 00m 55s)