Maniphest T185729

&veaction=edit URL parameter does not work on mobile site
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

URLs like https://meta.m.wikimedia.org/w/index.php?title=Main_Page&veaction=edit don't open VE. If you remove the "m." from the URL, it does work.

I think this is because the code handling veaction lives in DesktopArticleTarget.init.js and doesn't run on mobile. This breaks the useve=true functionality in <inputbox> on mobile, see e.g. https://meta.m.wikimedia.org/w/index.php?title=Grants:IdeaLab/Inspire&oldid=17677561

Details

	Subject	Repo	Branch	Lines +/-
	Intercept desktop editor links	mediawiki/skins/MinervaNeue	master	+32 -4

Customize query in gerrit

Related Objects

Mentioned In: T197834: Regression: Editing workflow broken for non-JS users and template editors on mobile
T196915: Give mobile editor a way to edit more than just a single section at once
T196150: Regression: Links containing "action" always show the editor on mobile version regardless of value
T195528: Issues with the mobile editor on Wikimedia Commons

Event Timeline

Catrope created this task.Jan 26 2018, 12:38 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2018, 12:38 AM

Change 434071 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/skins/MinervaNeue@master] Intercept desktop editor links

https://gerrit.wikimedia.org/r/434071

gerritbot added a project: Patch-For-Review.May 19 2018, 8:11 PM

DLynch claimed this task.May 19 2018, 8:13 PM

DLynch edited projects, added VisualEditor (Current work); removed VisualEditor.

DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 434071 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Intercept desktop editor links

https://gerrit.wikimedia.org/r/434071

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.May 20 2018, 5:29 PM

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki, VisualEditor-MediaWiki-Mobile; removed Patch-For-Review.

Jdforrester-WMF set the point value for this task to 1.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 20 2018, 6:00 PM

matmarex mentioned this in T195528: Issues with the mobile editor on Wikimedia Commons.May 24 2018, 11:12 PM

• Deskana closed this task as Resolved.May 28 2018, 3:39 PM

• Deskana triaged this task as Medium priority.

Jdlrobson mentioned this in T196150: Regression: Links containing "action" always show the editor on mobile version regardless of value.Jun 4 2018, 2:48 PM

Jdlrobson mentioned this in T196915: Give mobile editor a way to edit more than just a single section at once.Jun 15 2018, 5:29 PM

Jdlrobson mentioned this in T197834: Regression: Editing workflow broken for non-JS users and template editors on mobile.Jun 21 2018, 3:31 PM