Maniphest T185747

SurfaceSynchronizer: nameChange is emitted twice on connect
Closed, ResolvedPublic1 Story Points
Actions

Description

Steps to reproduce:

Open the rebaser demo, with a breakpoint inside the rebaser at emit( 'nameChange', ... ) .

Expected behaviour: onNameChange runs once.

Actual behaviour: onNameChange runs twice.

This is because the recursion guard in ve.ui.AuthorListPopupTool is vanquished by a debounce.

Details

Related Gerrit Patches:

mediawiki/extensions/VisualEditor : master	Update VE core submodule to master (c5fddd508)
VisualEditor/VisualEditor : master	Move updatingName recursion guard out of debounce

Related Objects

Mentioned Here: rGVEDc5fddd50883f: Merge "Rebaser: uninitialize fully"

Event Timeline

dchan created this task.Jan 26 2018, 11:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2018, 11:15 AM

dchan updated the task description. (Show Details)Jan 26 2018, 11:21 AM

Change 406273 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] Move updatingName recursion guard out of debounce

https://gerrit.wikimedia.org/r/406273

gerritbot added a project: Patch-For-Review.Jan 26 2018, 11:24 AM

Change 406273 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Move updatingName recursion guard out of debounce

https://gerrit.wikimedia.org/r/406273

Change 405751 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

Change 405751 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

https://gerrit.wikimedia.org/r/405751

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 29 2018, 5:00 PM

Jdforrester-WMF closed this task as Resolved.Jan 29 2018, 5:16 PM

Jdforrester-WMF assigned this task to dchan.

Jdforrester-WMF triaged this task as Medium priority.

Jdforrester-WMF set the point value for this task to 1.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Jdforrester-WMF removed a project: Patch-For-Review.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 29 2018, 5:16 PM

Ryasmeen moved this task from To be Verified to Non verifiable/Task on the User-Ryasmeen board.Mar 19 2018, 10:15 PM

SurfaceSynchronizer: nameChange is emitted twice on connectClosed, ResolvedPublic1 Story PointsActions