Page MenuHomePhabricator
Create Task
Maniphest T185761

Make i18n keys in WikibaseLexeme consistent
Closed, ResolvedPublic
Actions

Description

Right now, some i18n keys in the extension start with "wikibaselexeme", some start with "wikibase-lexeme" and some even with "wikibase". This should be unified into "wikibaselexeme" as for i18n coding convention they should start with extension name.

Details

SubjectRepoBranchLines +/-
Make i18n keys in WikibaseLexeme consistentmediawiki/extensions/WikibaseLexememaster+132 -130
Customize query in gerrit

Related Objects

Event Timeline

Ladsgroup created this task.Jan 26 2018, 3:17 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 26 2018, 3:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Jan 26 2018, 3:48 PM

Change 406293 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Make i18n keys in WikibaseLexeme consistent

https://gerrit.wikimedia.org/r/406293

gerritbot added a project: Patch-For-Review.Jan 26 2018, 3:48 PM
Ladsgroup moved this task from Backlog to Review on the Wikidata-Sprint-2018-01-17 board.Jan 26 2018, 3:49 PM
Ladsgroup mentioned this in rEWLE90da3df228a3: Make i18n keys in WikibaseLexeme consistent.Jan 26 2018, 3:51 PM
WMDE-leszek triaged this task as Low priority.Jan 26 2018, 5:10 PM
Ladsgroup moved this task from Incoming to Blocked on others on the User-Ladsgroup board.Jan 27 2018, 11:49 AM
WMDE-leszek renamed this task from Make i18n keys in WikibaseLexeme consistent to Make i18n keys in WikibaseLexeme consistent .Jan 30 2018, 9:45 AM
WMDE-leszek renamed this task from Make i18n keys in WikibaseLexeme consistent to Make i18n keys in WikibaseLexeme consistent (days: 1).
WMDE-leszek renamed this task from Make i18n keys in WikibaseLexeme consistent (days: 1) to Make i18n keys in WikibaseLexeme consistent (days: 2).Jan 30 2018, 2:01 PM
WMDE-leszek added a project: Wikidata-Sprint-2018-01-31.
WMDE-leszek moved this task from Backlog to Review on the Wikidata-Sprint-2018-01-31 board.
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Jan 30 2018, 2:21 PM
WMDE-leszek mentioned this in rEWLE913d3e57930a: Make i18n keys in WikibaseLexeme consistent.Jan 30 2018, 6:14 PM
WMDE-leszek mentioned this in rEWLEa731a692bec0: Make i18n keys in WikibaseLexeme consistent.Jan 30 2018, 6:16 PM
WMDE-leszek renamed this task from Make i18n keys in WikibaseLexeme consistent (days: 2) to Make i18n keys in WikibaseLexeme consistent (days: 3).Jan 31 2018, 11:23 AM
WMDE-leszek mentioned this in rEWLE6d432fc11861: Make i18n keys in WikibaseLexeme consistent.Jan 31 2018, 12:38 PM
WMDE-leszek mentioned this in rEWLE27d2f9187363: Make i18n keys in WikibaseLexeme consistent.Jan 31 2018, 1:21 PM
WMDE-leszek mentioned this in rEWLE1bcb3db33825: Make i18n keys in WikibaseLexeme consistent.Jan 31 2018, 5:46 PM
thiemowmde mentioned this in rEWLEbbeeb974014a: Make i18n keys in WikibaseLexeme consistent.Jan 31 2018, 5:50 PM
WMDE-leszek mentioned this in rEWLE47d571d10e46: Make i18n keys in WikibaseLexeme consistent.Feb 1 2018, 9:31 AM
WMDE-leszek renamed this task from Make i18n keys in WikibaseLexeme consistent (days: 3) to Make i18n keys in WikibaseLexeme consistent (days: 4).Feb 1 2018, 11:13 AM
WMDE-leszek renamed this task from Make i18n keys in WikibaseLexeme consistent (days: 4) to Make i18n keys in WikibaseLexeme consistent (days: 5).Feb 2 2018, 11:21 AM
thiemowmde mentioned this in rEWLE2346cc2a65e3: Make i18n keys in WikibaseLexeme consistent.Feb 2 2018, 3:26 PM
Amire80 added a project: I18n.Feb 3 2018, 3:22 PM
Amire80 moved this task from Untriaged to Message keys names on the I18n board.Feb 3 2018, 3:29 PM
WMDE-leszek renamed this task from Make i18n keys in WikibaseLexeme consistent (days: 5) to Make i18n keys in WikibaseLexeme consistent (days: 6).Feb 5 2018, 11:51 AM
WMDE-leszek mentioned this in rEWLE359b74fb3524: Make i18n keys in WikibaseLexeme consistent.Feb 6 2018, 3:07 PM
WMDE-leszek added subscribers: Amire80, Raymond, Nikerabbit.Feb 6 2018, 3:20 PM

@Amire80 @Nikerabbit @Raymond: it has taken us a while, but it looks we're done with the message key rename.
Patches changing the keys are https://gerrit.wikimedia.org/r/#/c/406293/ and https://gerrit.wikimedia.org/r/#/c/408510/.
We haven't intentionally merged these ourselves, to allow you to do the update the right way.
If we should do anything else (e.g. squash two patches into one), please say so here, or on the patches. Thanks a lot!

Raymond added a comment.Feb 6 2018, 4:23 PM
In T185761#3949137, @WMDE-leszek wrote:

We haven't intentionally merged these ourselves, to allow you to do the update the right way.

I am OK with both patch sets. Feel free to merge, I will do the updates/renames on translatewiki.net then.

WMDE-leszek renamed this task from Make i18n keys in WikibaseLexeme consistent (days: 6) to Make i18n keys in WikibaseLexeme consistent (days: 7).Feb 7 2018, 8:30 AM
gerritbot added a comment.Feb 7 2018, 8:30 AM

Change 406293 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Make i18n keys in WikibaseLexeme consistent

https://gerrit.wikimedia.org/r/406293

WMDE-leszek added a comment.Feb 7 2018, 8:32 AM

Thanks @Raymond! CI had some hiccups yesterday evening, but now both patches are finally merged. Thank you for running updates on translatewiki!

WMDE-leszek renamed this task from Make i18n keys in WikibaseLexeme consistent (days: 7) to Make i18n keys in WikibaseLexeme consistent.Feb 7 2018, 10:38 AM
WMDE-leszek moved this task from Review to Done on the Wikidata-Sprint-2018-01-31 board.
Lydia_Pintscher moved this task from incoming to features/bugs for next release (editor experience improvements) on the Wikidata Lexicographical data board.Mar 7 2018, 6:13 PM
WMDE-leszek closed this task as Resolved.Mar 19 2018, 8:45 AM

It seems the migration has happened in https://gerrit.wikimedia.org/r/#/c/408921/. This in my eyes concludes the work on this task. Thanks all!

Amire80 mentioned this in T204379: Rename "wikibaselexeme-api-error-*" message keys to "apierror-wikibaselexeme-*.Sep 14 2018, 7:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL