Page MenuHomePhabricator

Remove 'SkinVectorStyleModules' hook
Closed, ResolvedPublic

Description

The SkinVectorStyleModules hook was introduced in 8b6ed4d08fa0f209fa835b906cd64c55a50cabf0, but doesn't seem to be used anywhere in Wikimedia Git per https://codesearch.wmflabs.org/search/?q=SkinVectorStyleModules.

The hook is quite generic and doesn't provide any context. If the hook is mainly intended for unconditionally adding modules to the output, then it is safe to keep in the proposed reality of T140664. But I suspect it wasn't used that way, that absence of context in this hook actually meant the caller would use global state about the page and/or the user to determine which modules to add. We should try to remove hooks of that nature, in favour of more declarative data sharing.

Details

Related Gerrit Patches:
mediawiki/skins/Vector : masterRemove 'SkinVectorStyleModules' hook
mediawiki/skins/Vector : masterDeprecate 'SkinVectorStyleModules' hook

Event Timeline

Krinkle created this task.Jan 26 2018, 6:31 PM

Change 406317 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/skins/Vector@master] Deprecate 'SkinVectorStyleModules' hook

https://gerrit.wikimedia.org/r/406317

Change 406318 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/skins/Vector@master] Remove 'SkinVectorStyleModules' hook

https://gerrit.wikimedia.org/r/406318

Change 406317 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Deprecate 'SkinVectorStyleModules' hook

https://gerrit.wikimedia.org/r/406317

Change 406318 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Remove 'SkinVectorStyleModules' hook

https://gerrit.wikimedia.org/r/406318

Jdforrester-WMF closed this task as Resolved.Jan 29 2018, 4:39 PM
Jdforrester-WMF assigned this task to Krinkle.