Page MenuHomePhabricator
Create Task
Maniphest T185928

New usermessage browser test is blocking merges in Minerva skin and Echo extension
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/#/c/406633/ introduced a browser test that is not compatible with the Echo extension and thus the Minerva skin.

Echo magically moves the usermessage div and when the browser test runs it cannot find the element in the page.

All patches in Minerva and Echo are currently rejected by Jenkins (and we can't override verified).
e.g. https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/13853/console on patch https://gerrit.wikimedia.org/r/#/c/406618/
AND
https://gerrit.wikimedia.org/r/#/c/405371/

It seems strange as the screenshot for the failure shows that the element is present in the page so it's unclear why this fails from the information provided.

Unrelated to Jenkins failure but worth considering:
It's also not clear why this browser test is in core given that the usermessage div is created by skins. Some skins do not make use of it, notably Minerva.

Details

SubjectRepoBranchLines +/-
Revert "selenium: add new message banner test to user spec"mediawiki/coremaster+1 -30
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jan 29 2018, 8:06 PM
Restricted Application added a project: Web-Team-Backlog. · View Herald TranscriptJan 29 2018, 8:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Jan 29 2018, 8:06 PM

Change 406633 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Revert "selenium: add new message banner test to user spec"

https://gerrit.wikimedia.org/r/406633

gerritbot added a project: Patch-For-Review.Jan 29 2018, 8:06 PM
Jdlrobson triaged this task as Unbreak Now! priority.Jan 29 2018, 8:07 PM
Jdlrobson moved this task from To Do to Blocked on Others on the Readers-Web-Kanbanana-Board-Old board.
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptJan 29 2018, 8:07 PM
Jdlrobson updated the task description. (Show Details)Jan 29 2018, 8:21 PM
Jdlrobson renamed this task from New usermessage browser test is blocking merges in Minerva skin to New usermessage browser test is blocking merges in Minerva skin and Echo extension.Jan 29 2018, 8:34 PM
Jdlrobson added a project: Notifications.
Jdlrobson updated the task description. (Show Details)
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 29 2018, 8:34 PM
gerritbot added a comment.Jan 29 2018, 8:55 PM

Change 406633 merged by jenkins-bot:
[mediawiki/core@master] Revert "selenium: add new message banner test to user spec"

https://gerrit.wikimedia.org/r/406633

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 29 2018, 9:00 PM
Jdlrobson moved this task from Incoming to 2017-18 Q3 on the Web-Team-Backlog board.Jan 30 2018, 5:21 PM
• jmatazzoni moved this task from Untriaged to External on the Collaboration-Team-Triage board.Jan 30 2018, 6:37 PM
Addshore added a comment.Jan 31 2018, 4:19 PM

It's also not clear why this browser test is in core given that the usermessage div is created by skins. Some skins do not make use of it, notably Minerva.

Sounds like this test indeed shouldn't live in core then, unless there is some other element that can be checked, but I doubt it.

Addshore added a comment.Jan 31 2018, 4:20 PM

Can this be closed as resolved now that the revert has happened?

Jdlrobson added a comment.Jan 31 2018, 4:25 PM

The test could be restored in Vector. This would give us coverage for desktop at least, but it may need to be updated to be compatible with Echo.

I'd leave that decision up to those who originally worked on this, but yes if that's not going to happen this can be closed.

Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.Jan 31 2018, 4:26 PM
Addshore added a comment.Jan 31 2018, 4:27 PM

It could indeed be moved to Vector, do vector browser tests get run with mediawiki core merges?
@zeljkofilipin any idea? :)

Jdlrobson moved this task from Blocked on Others to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Jan 31 2018, 6:14 PM
Jdlrobson removed projects: Readers-Web-Kanbanana-Board-Old, Web-Team-Backlog.
zeljkofilipin added a comment.Feb 19 2018, 5:12 PM
In T185928#3934433, @Addshore wrote:

do vector browser tests get run with mediawiki core merges?

No, since Vector has no tests at all. :)

zeljkofilipin added a comment.Feb 19 2018, 5:13 PM
In T185928#3934433, @Addshore wrote:

It could indeed be moved to Vector

Do you volunteer? ;)

zeljkofilipin added a project: User-zeljkofilipin.Feb 19 2018, 5:13 PM
zeljkofilipin added a comment.Feb 21 2018, 9:59 AM
In T185928#3934433, @Addshore wrote:

It could indeed be moved to Vector

Tracked in T187859.

zeljkofilipin added a parent task: T182421: Q3 Selenium framework improvements.Feb 21 2018, 10:11 AM
zeljkofilipin removed a parent task: T182421: Q3 Selenium framework improvements.
zeljkofilipin mentioned this in T187859: Move one Selenium tests from mediawiki/core to mediawiki/skins/Vector.Feb 21 2018, 10:13 AM
zeljkofilipin added a comment.Feb 21 2018, 12:33 PM
In T185928#3934433, @Addshore wrote:

It could indeed be moved to Vector, do vector browser tests get run with mediawiki core merges?

Just checked, they do! :)

 - name: mediawiki/skins/Vector
   template:
    - name: mwgate-composer
    - name: mwgate-npm
    - name: skin-tests
   test:
    - mediawiki-core-qunit-selenium-jessie
   gate-and-submit: &mediawiki-skins-vector-gate-and-submit
    - mediawiki-core-qunit-selenium-jessie
gate-and-submit-swat: *mediawiki-skins-vector-gate-and-submit

https://phabricator.wikimedia.org/source/integration-config/browse/master/zuul/layout.yaml;798cef23962bfd4e0d5da4c3f031e84b4d036246$2145-2149

zeljkofilipin moved this task from Backlog 🪒 to Q4 👔 on the User-zeljkofilipin board.Feb 21 2018, 12:35 PM
gerritbot added a comment.Feb 21 2018, 1:00 PM

Change 413157 had a related patch set uploaded (by Zfilipin; owner: Addshore):
[mediawiki/skins/Vector@master] WIP Move one Selenium tests from mediawiki/core

https://gerrit.wikimedia.org/r/413157

zeljkofilipin added a subtask: T187859: Move one Selenium tests from mediawiki/core to mediawiki/skins/Vector.Feb 21 2018, 1:16 PM
zeljkofilipin claimed this task.Feb 21 2018, 1:19 PM
Restricted Application edited projects, added Release-Engineering-Team (Kanban); removed Release-Engineering-Team. · View Herald TranscriptFeb 21 2018, 1:19 PM
zeljkofilipin closed this task as Resolved.Feb 21 2018, 1:20 PM
zeljkofilipin moved this task from Untriaged to In-progress on the Continuous-Integration-Infrastructure board.
zeljkofilipin moved this task from Q4 👔 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.

Resolved in T187859. Please reopen or comment if there is something else to do here.

Liuxinyu970226 unsubscribed.Feb 21 2018, 1:32 PM
zeljkofilipin changed the status of subtask T187859: Move one Selenium tests from mediawiki/core to mediawiki/skins/Vector from Open to Stalled.Mar 29 2018, 9:12 AM
zeljkofilipin closed subtask T187859: Move one Selenium tests from mediawiki/core to mediawiki/skins/Vector as Resolved.Oct 7 2021, 3:27 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptOct 7 2021, 3:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL