| matmarex | |
| Jan 30 2018, 12:39 AM |
| F65764450: image.png | |
| Aug 17 2025, 2:32 AM |
| F12878157: image.png | |
| Jan 30 2018, 12:39 AM |
| F12878154: image.png | |
| Jan 30 2018, 12:39 AM |
Timeless displays an empty sidebar section on pages connected to a Wikidata item but with no language links. For example: https://www.mediawiki.org/wiki/Extension:VisualEditor?useskin=timeless
This section should probably have a heading and a link below the list of items, like this in Vector:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| fix: hide sidebars with all hidden portlets | mediawiki/skins/Timeless | master | +22 -3 |
This has been fixed in https://gerrit.wikimedia.org/r/404619 (previously reported in T181362#3899691)
Change #1179263 had a related patch set uploaded (by Perryprog; author: Perryprog):
[mediawiki/skins/Timeless@master] fix: hide sidebars with all hidden portlets
I don't see a regression here. The problem in 2018 was that the "Languages" sidebar was displaying as empty when it should have had content, this was fixed and it still works correctly. The new problem seems to be that some different sidebar is displaying as empty when it should be just hidden.
Ah, yeah, you're right—this isn't exactly a regression, though the portlet in the screenshot above is for language links. It's just that on wikidata there's nowhere to link to, so there it's truly empty, without even an "Add links" button.
And apparently I didn't even read your original issue (the second image specifically) fully—sorry about that!
Change #1179263 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] fix: hide sidebars with all hidden portlets
