Wikibase sqlite Jenkins builds failing due to obscure exception in RevisionStore
Closed, ResolvedPublic
Actions

Description

See e.g. https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests-sqlite-hhvm-jessie/5080/console related to https://gerrit.wikimedia.org/r/#/c/406302/ (documentation change).

From the log:

Could not insert main page: RevisionStore for cannot be used with a DB connection for jenkins_u0_mw

Interestingly enough, mysql builds seem to be fine?

@Addshore kindly pointed that the similar exception has been observed in T183914. Now it is somehow back again.

Wild guess of mine is that https://gerrit.wikimedia.org/r/#/c/406789/2/includes/Storage/RevisionStore.php might have somehow caused this (although my brain is too small to find the connection).

Details

Related Gerrit Patches:

mediawiki/core : master

Revert "Remove workaround for comparing database domain IDs."

Related Objects

Mentioned Here: T183777: Some PHPUnit tests consistently fail when collecting coverage report
T183914: RevisionStore::checkDatabaseWikiId is broken in some cases

Event Timeline

Revert submitted as https://gerrit.wikimedia.org/r/#/c/406840

Change 406840 had a related patch set uploaded (by WMDE-leszek; owner: Addshore):
[mediawiki/core@master] Revert "Remove workaround for comparing database domain IDs."

https://gerrit.wikimedia.org/r/406840

gerritbot added a project: Patch-For-Review.Jan 30 2018, 5:55 PM

Arlolra added a subscriber: Arlolra.Jan 30 2018, 8:18 PM

Krinkle added a project: Performance-Team.Jan 31 2018, 12:04 AM

Krinkle added a project: Wikimedia-Rdbms.

Krinkle removed a project: Wikimedia-Rdbms.

The code coverage build is also broken by this, at https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage-php7/56/console

Build

+ /srv/deployment/integration/slave-scripts/bin/mw-install-sqlite.sh
03:00:11 PHP 5.6.33-0+deb8u1 is installed.
03:00:11 [..]
03:00:11 Creating main page with default content
03:00:11 Could not insert main page: RevisionStore for  cannot be used with a DB connection for jenkins_u0_mw
03:00:11 
03:00:11 PHP Notice:  Uncommitted DB writes (transaction from WikiPage::doCreate). in /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage-php7/src/includes/libs/rdbms/database/Database.php on line 3779
03:00:11 PHP Notice:  DB transaction writes or callbacks still pending (WikiPage::insertOn/single-row). in /srv/jenkins-workspace/workspace/mediawiki-core-code-coverage-php7/src/includes/libs/rdbms/database/Database.php on line 3785
03:00:12 Build step 'Execute shell' marked build as failure

Change 406840 merged by jenkins-bot:
[mediawiki/core@master] Revert "Remove workaround for comparing database domain IDs."

https://gerrit.wikimedia.org/r/406840

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 31 2018, 4:00 AM

This is an sqlite issue, and T183777 might also hit and another underlying issue here with sqlite and RevisionStore

@Addshore Can this task be closed? The revert was merged, and the original issue (inability to merge https://gerrit.wikimedia.org/r/406302) also seems solved.