Page MenuHomePhabricator

svg_check.sh broken
Closed, ResolvedPublic

Description

When executed locally or in CI, svg_check.sh reports many errors but finishes with a successful status:

wc: resources/mobile.issues.images/gray-triangle.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 316: unary operator expected
rm: cannot remove 'resources/mobile.issues.images/gray-triangle.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.pagesummary.styles/noimage.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 390: unary operator expected
rm: cannot remove 'resources/mobile.pagesummary.styles/noimage.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.startup/images/error.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 544: unary operator expected
rm: cannot remove 'resources/mobile.startup/images/error.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.editor.common/images/editVeNormal.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 429: unary operator expected
rm: cannot remove 'resources/mobile.editor.common/images/editVeNormal.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.editor.common/images/editSourceNormal.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 549: unary operator expected
rm: cannot remove 'resources/mobile.editor.common/images/editSourceNormal.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.special.user.icons/userAnonymous.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 701: unary operator expected
rm: cannot remove 'resources/mobile.special.user.icons/userAnonymous.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.special.user.icons/userNormal.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 609: unary operator expected
rm: cannot remove 'resources/mobile.special.user.icons/userNormal.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.userpage.icons/talk.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 274: unary operator expected
rm: cannot remove 'resources/mobile.userpage.icons/talk.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.userpage.icons/userpage.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 1776: unary operator expected
rm: cannot remove 'resources/mobile.userpage.icons/userpage.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.toc.images/contents-ltr.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 554: unary operator expected
rm: cannot remove 'resources/mobile.toc.images/contents-ltr.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.ajax.styles/images/refresh.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 454: unary operator expected
rm: cannot remove 'resources/mobile.ajax.styles/images/refresh.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.startup.images/error.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 544: unary operator expected
rm: cannot remove 'resources/mobile.startup.images/error.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.startup.images/watch.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 413: unary operator expected
rm: cannot remove 'resources/mobile.startup.images/watch.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.startup.images/watched.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 226: unary operator expected
rm: cannot remove 'resources/mobile.startup.images/watched.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.references.images/cite.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 426: unary operator expected
rm: cannot remove 'resources/mobile.references.images/cite.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.startup.images.variants/back-ltr.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 196: unary operator expected
rm: cannot remove 'resources/mobile.startup.images.variants/back-ltr.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.startup.images.variants/back-rtl.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 197: unary operator expected
rm: cannot remove 'resources/mobile.startup.images.variants/back-rtl.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.startup.images.variants/close.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 327: unary operator expected
rm: cannot remove 'resources/mobile.startup.images.variants/close.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.startup.images.variants/arrow.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 288: unary operator expected
rm: cannot remove 'resources/mobile.startup.images.variants/arrow.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.search.images/clear.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 390: unary operator expected
rm: cannot remove 'resources/mobile.search.images/clear.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.search.images/search-content.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 1008: unary operator expected
rm: cannot remove 'resources/mobile.search.images/search-content.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.special.mobilediff.images/bytes-removed.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 242: unary operator expected
rm: cannot remove 'resources/mobile.special.mobilediff.images/bytes-removed.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.special.mobilediff.images/bytes-added.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 242: unary operator expected
rm: cannot remove 'resources/mobile.special.mobilediff.images/bytes-added.svg.tmp': No such file or directory
Unknown option: -q
wc: resources/mobile.special.mobilediff.images/bytes-neutral.svg.tmp: No such file or directory
dev-scripts/svg_check.sh: line 7: [: 244: unary operator expected
rm: cannot remove 'resources/mobile.special.mobilediff.images/bytes-neutral.svg.tmp': No such file or directory

This task encompasses the work to resolve the errors and improve the script so that failures will be noticed.

Event Timeline

Are you saying this is currently not working when we submit patches? e.g. people are able to upload uncompressed SVGs?

Change 408547 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: svg_check.sh and uncompressed SVGs

https://gerrit.wikimedia.org/r/408547

Jdlrobson claimed this task.

Thanks for fixing this Stephen!

Change 408547 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: svg_check.sh and uncompressed SVGs

https://gerrit.wikimedia.org/r/408547

Change 409030 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: use recommended SVGO optimization config

https://gerrit.wikimedia.org/r/409030

Change 409030 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: use recommended SVGO optimization config

https://gerrit.wikimedia.org/r/409030