Page MenuHomePhabricator
Create Task
Maniphest T186037

Need mvn build mode that does not build gui
Closed, ResolvedPublic
Actions

Description

Right now mvn build also builds GUI, which is great for final package, but sometimes we need a quick build that just builds Java files. There should be some option to skip building GUI in this case.

Details

SubjectRepoBranchLines +/-
Move the gui module to a gui profilewikidata/query/rdfmaster+15 -1
Customize query in gerrit

Event Timeline

Smalyshev created this task.Jan 30 2018, 6:57 PM
Restricted Application added projects: Wikidata, Discovery-ARCHIVED. · View Herald TranscriptJan 30 2018, 6:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Smalyshev triaged this task as Low priority.Jan 30 2018, 11:11 PM

Turns out -pl \!gui,\!dist works, but I wonder if possible to make some kind of profile that does the same?

Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Mar 5 2018, 4:13 PM
Gehel added a comment.Jun 25 2019, 8:18 AM

We could define the GUI module in a profile and disable that profile as needed (-P !gui). Some ideas: https://stackoverflow.com/questions/13381179/using-profiles-to-control-which-maven-modules-are-built

dcausse claimed this task.Jul 16 2019, 4:35 PM
dcausse added a project: Discovery-Wikidata-Query-Service-Sprint.
dcausse moved this task from Backlog to In progress on the Discovery-Wikidata-Query-Service-Sprint board.
dcausse added a comment.Jul 17 2019, 10:58 AM

We could also use mvn -pl -gui which does not require any changes

gerritbot added a comment.Jul 17 2019, 11:27 AM

Change 523905 had a related patch set uploaded (by DCausse; owner: DCausse):
[wikidata/query/rdf@master] Move the gui module to a gui profile

https://gerrit.wikimedia.org/r/523905

gerritbot added a project: Patch-For-Review.Jul 17 2019, 11:27 AM
Smalyshev moved this task from In progress to Needs review on the Discovery-Wikidata-Query-Service-Sprint board.Jul 17 2019, 11:00 PM
gerritbot added a comment.Jul 17 2019, 11:54 PM

Change 523905 merged by jenkins-bot:
[wikidata/query/rdf@master] Move the gui module to a gui profile

https://gerrit.wikimedia.org/r/523905

Smalyshev closed this task as Resolved.Jul 18 2019, 12:04 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 18 2019, 12:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL