Return full objects from POST and PUT endpoints for reading lists and reading list entries
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JoeWalsh
	Jan 30 2018, 7:37 PM

Description

Currently, the POST and PUT endpoints for lists and entries only return the ids of the list or entry.

Ideally, these would return the full objects, including created and updated dates. The same should be true for the duplicate responses T184680.

The created and updated dates could then be used for sorting locally.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Return result row after insert/update	mediawiki/extensions/ReadingLists	wmf/1.31.0-wmf.23	+182 -94
	Return result row after insert/update	mediawiki/extensions/ReadingLists	master	+182 -94

Customize query in gerrit

Related Objects

Mentioned In: rERLS721840a441e8: Return result row after insert/update
rERLS4d77be3ebd71: Return result row after insert/update
rERLSa2bdd9546d14: Return result row after insert/update
rERLSaf124851a329: Return result row after insert/update
rERLSaf874eef931b: Return result row after insert/update
rERLSd94fa34f752f: Return result row after insert/update
rERLS067ca13330d5: Return result row after insert/update
rERLSac6d54655639: Return result row after insert/update
Mentioned Here: T182706: Make sure apps can continue /changes/since where they left off
T184680: Update duplicate handling in reading lists API

Event Timeline

JoeWalsh created this task.Jan 30 2018, 7:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 30 2018, 7:37 PM

JoeWalsh updated the task description. (Show Details)Jan 30 2018, 7:37 PM

• Fjalapeno added a project: Reading List Service.Jan 30 2018, 7:40 PM

JoeWalsh renamed this task from Return full objects from POST and PUT endpoints for reading lists to Return full objects from POST and PUT endpoints for reading lists and reading list entries.Jan 30 2018, 7:41 PM

@Tgr this came out of the need for supporting client side ordering - this seemed reasonable to me, does it look ok to you as well?

@JoeWalsh can you speak to priority of this one relative to T184680 and T182706?

1st T182706 2nd this ticket 3rd T184680

I don't see any problem with it.

Cool, thanks moving to the Kanban board then

Tgr moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Feb 8 2018, 11:17 PM

Change 413650 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@master] Return result row after insert/update

https://gerrit.wikimedia.org/r/413650

gerritbot added a project: Patch-For-Review.Feb 23 2018, 1:09 AM

Tgr mentioned this in rERLSac6d54655639: Return result row after insert/update.Feb 23 2018, 1:13 AM

Tgr mentioned this in rERLS067ca13330d5: Return result row after insert/update.Feb 23 2018, 1:20 AM

Tgr moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Feb 23 2018, 1:21 AM

Tgr moved this task from Code Review to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

RESTBase PR is #960.

Tgr moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Feb 23 2018, 3:02 AM

Tgr moved this task from Code Review to Blocked on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Tgr mentioned this in rERLSd94fa34f752f: Return result row after insert/update.Mar 5 2018, 1:09 AM

Tgr mentioned this in rERLSaf874eef931b: Return result row after insert/update.Mar 5 2018, 5:07 AM

Tgr mentioned this in rERLSaf124851a329: Return result row after insert/update.Mar 5 2018, 7:22 AM

Tgr mentioned this in rERLSa2bdd9546d14: Return result row after insert/update.Mar 5 2018, 7:29 AM

• Mholloway mentioned this in rERLS4d77be3ebd71: Return result row after insert/update.Mar 5 2018, 7:40 PM

Change 413650 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Return result row after insert/update

https://gerrit.wikimedia.org/r/413650

Tgr moved this task from Blocked to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Mar 5 2018, 9:59 PM

Change 416612 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/ReadingLists@wmf/1.31.0-wmf.23] Return result row after insert/update

https://gerrit.wikimedia.org/r/416612

Tgr mentioned this in rERLS721840a441e8: Return result row after insert/update.Mar 6 2018, 12:30 AM

Change 416612 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@wmf/1.31.0-wmf.23] Return result row after insert/update

https://gerrit.wikimedia.org/r/416612

Tgr moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Mar 6 2018, 2:23 AM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Mar 6 2018, 3:01 PM

Tgr closed this task as Resolved.Mar 10 2018, 12:56 AM