Page MenuHomePhabricator

Special:EditMassMessageList serves Error 500
Closed, ResolvedPublic

Description

I was about to update a MassMessage list using https://meta.wikimedia.org/wiki/Special:EditMassMessageList/Meta:Administrators/Mass-message_list. Each time I've tried the result is an Error 500.

Request from <redacted IP> via cp3031 cp3031, Varnish XID 269356886
Error: 500, Internal Server Error at Wed, 31 Jan 2018 10:34:21 GMT

The rest of Special pages I've checked work well.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2018, 10:36 AM
MarcoAurelio triaged this task as High priority.Jan 31 2018, 10:36 AM
revi added a subscriber: revi.Jan 31 2018, 11:20 AM

Clicking "remove" in the list page works. diff

Still, trying to edit the whole list with the edit tab at the top of the page serves HTTP ERROR 500. No idea.

Joe added a subscriber: Joe.Jan 31 2018, 11:35 AM

The error seems to be:

Fatal error: Class undefined: MediaWiki\MassMessage\MWNamespace in /srv/mediawiki/php-1.31.0-wmf.17/extensions/MassMessage/includes/SpecialEditMassMessageList.php on line 123
    // Protection warnings; modified from EditPage::showHeader()
    if ( $this->title->isProtected( 'edit' )
      && MWNamespace::getRestrictionLevels( $this->title->getNamespace() ) !== [ '' ]
    ) {
      if ( $this->title->isSemiProtected() ) {
        $noticeMsg = 'semiprotectedpagewarning';
      } else { // Full protection
        $noticeMsg = 'protectedpagewarning';
      }
      LogEventsList::showLogExtract( $out, 'protect', $this->title, '',
        [ 'lim' => 1, 'msgKey' => [ $noticeMsg ] ] );
    }
  }
}

so I went ahead and unprotected the MassMessageList (was protected [edit=sysop, move=sysop] and I am a sysop fwiw) and now I can edit it without issues. But in any case I should have been able to edit it nonetheless previously and, if not, a proper error message should've been displayed, not an Error 500 :)

Change 406988 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/MassMessage@master] WIP/DNM Fix MWNamespace::getRestrictionLevels for MassMessage

https://gerrit.wikimedia.org/r/406988

Change 406988 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Use MWNamespace & LogEventsList

https://gerrit.wikimedia.org/r/406988

MarcoAurelio closed this task as Resolved.Jan 31 2018, 5:46 PM
MarcoAurelio claimed this task.

I'll think about asking for a backport to the actual MediaWiki version or wait for the next train.

Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptJan 31 2018, 5:46 PM