Page MenuHomePhabricator

Toolbar icons and captions are not visible on full screen image gallery view
Closed, ResolvedPublic

Assigned To
Authored By
RHo
Jan 31 2018, 5:24 PM
Referenced Files
F13154104: image.png
Feb 6 2018, 10:58 PM
F13134440: image.png
Feb 6 2018, 6:22 PM
F13134349: image.png
Feb 6 2018, 6:22 PM
F13134446: image.png
Feb 6 2018, 6:22 PM
F12919761: POTD - full screen - zoomed.png
Jan 31 2018, 5:24 PM
F12919776: image.png
Jan 31 2018, 5:24 PM

Description

Steps to reproduce
  1. Go to an article with an image that is portrait and full screen – the lead image for the "12 Angry Men (1957 film)" article
  2. Tap on the lead image to open it in full screen view
Expected

There is a semi-transparent black scrim behind the toolbar icons and caption to render them visible when the image extends to the height of the screen

POTD - full screen - zoomed.png (1×720 px, 1 MB)

Actual

Toolbar icons and caption is barely visible due to insufficient opacity in the scrim.

image.png (1×1 px, 1 MB)

Event Timeline

Change 407041 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Improve toolbar and bottom gradient in GalleryActivity.

https://gerrit.wikimedia.org/r/407041

Change 407041 merged by jenkins-bot:
[apps/android/wikipedia@master] Improve toolbar and bottom gradient in GalleryActivity.

https://gerrit.wikimedia.org/r/407041

hi @Dbrant - whilst the gradient looks better now on Nexus 5 (6.0.1), Wikipedia v2.7.224-alpha-2018-02-06, just noticed a visual regression in that the image gallery background should be completely black (see screenshots below). Did you want me to create a separate ticket or keep on this one?
Gradient is fixed

image.png (1×1 px, 1 MB)

Image gallery background color is not #000000 as expected

Expected (per v2.6.198-releasesprod-2017-06-09)
image.png (1×1 px, 1 MB)
Actual (v2.7.224-alpha-2018-02-06)
image.png (1×1 px, 1 MB)

Change 408572 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Set gallery background to full black.

https://gerrit.wikimedia.org/r/408572

Change 408572 merged by jenkins-bot:
[apps/android/wikipedia@master] Set gallery background to full black.

https://gerrit.wikimedia.org/r/408572

Great. LGTM on the latest version of Wikipedia, v2.7.224-alpha-2018-02-06 at 11:06:02 PT.

image.png (1×1 px, 1 MB)