Toolbar icons and captions are not visible on full screen image gallery view
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RHo
	Jan 31 2018, 5:24 PM

Description

Steps to reproduce

Go to an article with an image that is portrait and full screen – the lead image for the "12 Angry Men (1957 film)" article
Tap on the lead image to open it in full screen view

Expected

There is a semi-transparent black scrim behind the toolbar icons and caption to render them visible when the image extends to the height of the screen

POTD - full screen - zoomed.png (1×720 px, 1 MB)

Actual

Toolbar icons and caption is barely visible due to insufficient opacity in the scrim.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Set gallery background to full black.	apps/android/wikipedia	master	+1 -1
	Improve toolbar and bottom gradient in GalleryActivity.	apps/android/wikipedia	master	+54 -67

Customize query in gerrit

Event Timeline

RHo created this task.Jan 31 2018, 5:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2018, 5:24 PM

Change 407041 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Improve toolbar and bottom gradient in GalleryActivity.

https://gerrit.wikimedia.org/r/407041

gerritbot added a project: Patch-For-Review.Jan 31 2018, 7:00 PM

Dbrant claimed this task.Feb 1 2018, 4:20 PM

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.23x-G-Grape on the Wikipedia-Android-App-Backlog board.

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape); removed Wikipedia-Android-App-Backlog.

Restricted Application edited projects, added Wikipedia-Android-App-Backlog; removed Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape). · View Herald TranscriptFeb 1 2018, 4:20 PM

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.23x-G-Grape on the Wikipedia-Android-App-Backlog board.Feb 1 2018, 4:20 PM

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape); removed Wikipedia-Android-App-Backlog.

Dbrant moved this task from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape) board.Feb 1 2018, 4:25 PM

Change 407041 merged by jenkins-bot:
[apps/android/wikipedia@master] Improve toolbar and bottom gradient in GalleryActivity.

https://gerrit.wikimedia.org/r/407041

Dbrant moved this task from Code Review to Design Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G-Grape) board.Feb 6 2018, 3:38 PM

hi @Dbrant - whilst the gradient looks better now on Nexus 5 (6.0.1), Wikipedia v2.7.224-alpha-2018-02-06, just noticed a visual regression in that the image gallery background should be completely black (see screenshots below). Did you want me to create a separate ticket or keep on this one?
Gradient is fixed

Image gallery background color is not #000000 as expected

Expected (per v2.6.198-releasesprod-2017-06-09)

Actual (v2.7.224-alpha-2018-02-06)

Change 408572 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Set gallery background to full black.

https://gerrit.wikimedia.org/r/408572

Change 408572 merged by jenkins-bot:
[apps/android/wikipedia@master] Set gallery background to full black.