Maniphest T186225

[Bug][Regression] Tapping "Refresh location" in Nearby goes to search
Closed, ResolvedPublic
Actions

Description

Steps to reproduce

Visit https://en.m.wikipedia.org/wiki/Special:Nearby
Tap the "refresh location" button

Expected results

Results are updated using the user's current geolocation.

Actual results

An empty search page is shown (https://en.m.wikipedia.org/w/index.php?search=).

Environments observed

Browser Version:

Chromium v63.0.3239.132 (Official Build) Built on Ubuntu , running on Ubuntu 17.10 (64-bit)

OS Version:

Ubuntu v17.10 64b

Device Model:

Desktop

Device Language:

English

Testing criteria

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Nearby
Click refresh
Ensure list refreshes and no search action is performed.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	master	+3 -1	Fix refresh button on Special:Nearby page

Customize query in gerrit

Event Timeline

Niedzielski created this task.Feb 1 2018, 3:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2018, 3:27 PM

Jdlrobson renamed this task from [Bug] Tapping "Refresh location" in Nearby goes to search to [Bug][Regression] Tapping "Refresh location" in Nearby goes to search.Feb 1 2018, 6:19 PM

Oops. @ovasileva high or normal priority?

Jdlrobson added a project: good first task.Feb 1 2018, 6:24 PM

Jdlrobson added a project: Africa-Wikimedia-Developers.

xSavitar claimed this task.Feb 1 2018, 6:45 PM

xSavitar triaged this task as High priority.

xSavitar awarded a token.

xSavitar added a project: MobileFrontend.

xSavitar moved this task from Backlog to Tasks in progress (Doing) on the Africa-Wikimedia-Developers board.

xSavitar added a subscriber: xSavitar.

Change 407477 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/MobileFrontend@master] Fix refresh button on Special:Nearby page

https://gerrit.wikimedia.org/r/407477

xSavitar added a project: GeoData.Feb 1 2018, 6:47 PM

gerritbot added a project: Patch-For-Review.Feb 1 2018, 6:47 PM

@Jdlrobson, I remember we worked on a similar issue sometime ago? How come it has resurfaced? :) I've just checked and this is it, https://gerrit.wikimedia.org/r/#/c/372869/. But it's similar :)

xSavitar moved this task from Backlog to Tracking on the GeoData board.Feb 1 2018, 8:36 PM

xSavitar moved this task from Backlog to Team: web on the MobileFrontend board.

@Jdlrobson, the main issue for adding some css was to remove this effect on the button on-click;

Note the blue shadow around the button? But if this is not needed, I can remove it. Thanks :)

In T186225#3938371, @Jdlrobson wrote:

Oops. @ovasileva high or normal priority?

High works.

The main issue of the submitting search has been fixed by a volunteer.
@Volker_E and @Nirzar can you take a look and maybe open a follow up if we need to change anything with regards to the blue shadow per https://phabricator.wikimedia.org/T186225#3939176 ? Thanks!

Jdlrobson moved this task from To Do to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.Feb 1 2018, 10:29 PM

Jdlrobson moved this task from Triaged but Future to 2017-18 Q3 on the Readers-Web-Backlog board.

@Jdlrobson If I understand correctly, the refresh button pointed at the wrong action. This is fixed now.
Having a focus feedback is an essential from accessibility perspective. Why is the focus outline seen as problematic?

blue shadow is the focus ring, we need it. not problematic from design POV

Thanks all. Looks like some follow up might be needed anyhow.

@Jdlrobson, following @matmarex's comment on Gerrit, I've updated the patch to use <button type='button'>...</button> which also solves the issue of the blue shadow around the button when clicked. But the only issue now is Jenkins is reporting a failing build but this doesn't relate to the patch AFAIK. Any ideas?

Jdlrobson reassigned this task from • Nirzar to xSavitar.Feb 5 2018, 6:09 PM

Jenkins is now happy with the patch all of a sudden :) No need to worry again, @matmarex can confirm this!

Jdlrobson moved this task from Needs More Work to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Feb 5 2018, 6:48 PM

Change 407477 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix refresh button on Special:Nearby page

https://gerrit.wikimedia.org/r/407477

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Feb 5 2018, 7:00 PM

Over to you @ABorbaWMF - this will go out on the train tomorrow.

matmarex removed a subscriber: matmarex.Feb 5 2018, 8:53 PM

Sorry for the delay. I thought the train had not yet arrived because I was getting no results at all on nearby on Beta, but then realized there are no articles tagged with Alameda. This is working now on production.

ovasileva claimed this task.Feb 15 2018, 6:04 PM

ovasileva added a subscriber: ABorbaWMF.

all done!

xSavitar moved this task from Tasks in progress (Doing) to Technical Tasks (Completed) on the Africa-Wikimedia-Developers board.Feb 15 2018, 6:26 PM

[Bug][Regression] Tapping "Refresh location" in Nearby goes to searchClosed, ResolvedPublicActions