Page MenuHomePhabricator
Create Task
Maniphest T186250

latest varnishkafka fails to build on Debian
Closed, ResolvedPublic
Actions

Description

varnishkafka fails to build on Debian due to the use of the _BSD_SOURCE macro, which was deprecated starting with glibc version 2.20, included in Debian 9 (stretch) and later. This deprecated use of _BSD_SOURCE triggers a warning, which is treated as an error due to the -Werror flag in the Makefile.

Simply deleting the use of this macro (varnishkafka.c line 33) causes the build to succeed and presumably everything to work properly. The comment on that line says that the macro is needed for daemon(), but that function is apparently in glibc's default feature set anyway.

Details

SubjectRepoBranchLines +/-
Update to glibc >=2.19operations/software/varnish/varnishkafkamaster+8 -4
Customize query in gerrit

Related Objects

Event Timeline

Jrdnch created this task.Feb 1 2018, 7:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2018, 7:17 PM
Jrdnch updated the task description. (Show Details)Feb 1 2018, 7:17 PM
Liuxinyu970226 subscribed.Feb 5 2018, 10:59 AM

@Jrdnch thank you for reporting, but as you can see, the Varnish project is archived now, wondering if you could pick another project? Or otherwise we can just decline or invalid this task?

elukey edited projects, added Analytics, User-Elukey; removed Varnish.Feb 5 2018, 11:08 AM
elukey subscribed.

Going to triage/work on it as part of Analytics, thanks :)

• Nuria moved this task from Incoming to Dashiki on the Analytics board.Feb 5 2018, 5:24 PM
Jrdnch added a comment.Feb 5 2018, 8:02 PM

@Liuxinyu970226 Thanks, I wasn't aware that the Varnish project is archived.

elukey added a comment.Mar 19 2018, 10:09 AM

Very nice, just read http://man7.org/linux/man-pages/man3/daemon.3.html

daemon():
    Since glibc 2.21:
        _DEFAULT_SOURCE
    In glibc 2.19 and 2.20:
        _DEFAULT_SOURCE || (_XOPEN_SOURCE && _XOPEN_SOURCE < 500)
    Up to and including glibc 2.19:
        _BSD_SOURCE || (_XOPEN_SOURCE && _XOPEN_SOURCE < 500)
elukey added a comment.Mar 19 2018, 10:18 AM

@Jrdnch this issue will be probably fixed/worked on next quarter since it doesn't seem super pressing for our use case, but if you have time and you'd want to help feel free to send a patch!

elukey triaged this task as Low priority.Mar 19 2018, 10:18 AM
Jrdnch added a comment.EditedMar 19 2018, 3:39 PM

I can submit a patch. Thanks for the man page, that's helpful.

My patch would probably just remove the _BSD_SOURCE macro, since daemon() has been in _DEFAULT_SOURCE since glibc 2.19. The patch would introduce a dependency on glibc 2.19 or later.

It looks like glibc 2.19 was released in 2014. It's in Ubuntu 14.04 and Debian 8. Is that too recent? Alternatively, I could check the glibc version and conditionally enable _BSD_SOURCE. I think it's probably fine to leave it out, since varnishkafka requires librdkafka 0.9, which was released in 2016.

elukey added a subscriber: MoritzMuehlenhoff.Mar 19 2018, 3:43 PM
elukey added a comment.Mar 23 2018, 8:45 AM
In T186250#4061550, @Jrdnch wrote:

I can submit a patch. Thanks for the man page, that's helpful.

My patch would probably just remove the _BSD_SOURCE macro, since daemon() has been in _DEFAULT_SOURCE since glibc 2.19. The patch would introduce a dependency on glibc 2.19 or later.

It looks like glibc 2.19 was released in 2014. It's in Ubuntu 14.04 and Debian 8. Is that too recent? Alternatively, I could check the glibc version and conditionally enable _BSD_SOURCE. I think it's probably fine to leave it out, since varnishkafka requires librdkafka 0.9, which was released in 2016.

Confirmed in https://sourceware.org/glibc/wiki/Glibc%20Timeline, it seems that just removing _BSD_SOURCE would be the easiest thing to do, but it would also be great to highlight it in the documentation (https://github.com/wikimedia/varnishkafka#requirements).

elukey moved this task from Backlog to Analytics Backlog on the User-Elukey board.Mar 23 2018, 3:55 PM
Jrdnch added a comment.Mar 27 2018, 9:05 PM

Alright, I'll do both of those things.

gerritbot subscribed.Mar 28 2018, 3:51 PM

Change 422425 had a related patch set uploaded (by Jrdnch; owner: Jrdnch):
[operations/software/varnish/varnishkafka@master] Update to glibc >=2.19

https://gerrit.wikimedia.org/r/422425

gerritbot added a project: Patch-For-Review.Mar 28 2018, 3:51 PM
gerritbot added a comment.Mar 29 2018, 7:35 AM

Change 422425 merged by Elukey:
[operations/software/varnish/varnishkafka@master] Update to glibc >=2.19

https://gerrit.wikimedia.org/r/422425

elukey closed this task as Resolved.Mar 29 2018, 7:36 AM
elukey claimed this task.

Just merged the change, thanks a lot!

Liuxinyu970226 unsubscribed.Mar 29 2018, 11:51 AM
Jrdnch added a comment.Mar 29 2018, 2:41 PM

Great, thanks for your help all along the way!

Stashbot mentioned this in T200445: Upgrade cache servers to stretch.Jul 31 2018, 9:29 AM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-07-31T09:29:54Z] <ema> upload varnishkafka 1.0.13-1 to stretch-wikimedia T200445 T186250

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL