Page MenuHomePhabricator
Create Task
Maniphest T186267

Phase out legacy IDs now that HTML5 IDs are deployed everywhere
Open, Needs TriagePublic
Actions

Description

This ticket follows up the work done as part of T152540: Migrate to HTML5 section ids.

In T152540#3279587, @tstarling wrote:

Implementation proposal:

[…]

  • Wait for many years
  • Set $wgSectionFragmentFlavour to "html5"

Details

SubjectRepoBranchLines +/-
Change $wgExperimentalHtmlIds to HTML5-firstmediawiki/coremaster+5 -1
MWInternalLinkAnnotation: Make test work with both fragment modesmediawiki/extensions/VisualEditormaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

• Niharika created this task.Feb 1 2018, 9:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2018, 9:17 PM
• Niharika mentioned this in T152540: Migrate to HTML5 section ids.Feb 1 2018, 9:18 PM
cscott mentioned this in T186272: Convert all parser tests to html5 ids.Feb 1 2018, 9:46 PM
cscott subscribed.EditedFeb 1 2018, 9:50 PM

Probably the first step is to flip the DefaultSettings.php $wgFragmentMode from ['legacy','html5'] to ['html5','legacy'].

The comment for https://gerrit.wikimedia.org/r/405391 (2639f3350167a4331dfa6120b9a47c80b731f518) suggests this should be done for 1.35 LTS; we'd probably want to remove the deprecated $wgExperimentalHtmlIds around the same time (T139744: Remove $wgExperimentalHtmlIds (deprecated in 1.30)).

Note that we changed the default on WMF wikis to ['html5','legacy'] in 28a6ee5fc0b055125c0d6b036587f30a257b0ad0.

cscott added a subscriber: MaxSem.Feb 1 2018, 10:04 PM
IKhitron subscribed.Feb 1 2018, 10:12 PM
Platonides subscribed.Feb 2 2018, 1:46 AM

Cool anchors don't change.

Will all links using old anchors be updated? Even if the anchors are provided within full urls? What about links to a section from external pages?

Liuxinyu970226 subscribed.Feb 2 2018, 2:22 PM
Jack_who_built_the_house subscribed.Feb 2 2018, 2:39 PM
Ltrlg subscribed.Feb 5 2018, 1:21 PM
• TBolliger moved this task from New & TBD Tickets to Older: Tracking Work by Others on the Community-Tech board.Feb 6 2018, 10:50 PM
• TBolliger moved this task from Older: Tracking Work by Others to Older: Team Work on the Community-Tech board.Feb 14 2018, 6:41 PM
• TBolliger removed a project: Community-Tech.Feb 23 2018, 11:41 PM
MaxSem added projects: MediaWiki-Parser, Technical-Debt.Feb 23 2018, 11:48 PM

Section links break all the time because unlike page redirects there's nothing to help old links work when users edit section headings. That being said, my take on timeline for this would be "look at the situation around this in 5 years".

Dalba mentioned this in T133276: textlib.does_text_contain_section fails for encoded section title.Jan 27 2019, 5:15 AM
gerritbot added a comment.Sep 11 2021, 8:49 AM

Change 720427 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] Change $wgExperimentalHtmlIds to HTML5-first

https://gerrit.wikimedia.org/r/720427

gerritbot added a project: Patch-For-Review.Sep 11 2021, 8:49 AM
gerritbot added a comment.Sep 12 2021, 12:41 AM

Change 720460 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/VisualEditor@master] MWInternalLinkAnnotation: Make test work with both fragment modes

https://gerrit.wikimedia.org/r/720460

Krinkle updated the task description. (Show Details)Sep 12 2021, 4:10 AM
Krinkle added a subscriber: tstarling.
gerritbot added a comment.Sep 12 2021, 4:32 AM

Change 720460 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] MWInternalLinkAnnotation: Make test work with both fragment modes

https://gerrit.wikimedia.org/r/720460

gerritbot added a comment.Sep 12 2021, 4:32 AM

Change 720427 merged by jenkins-bot:

[mediawiki/core@master] Change $wgExperimentalHtmlIds to HTML5-first

https://gerrit.wikimedia.org/r/720427

Maintenance_bot removed a project: Patch-For-Review.Sep 12 2021, 5:10 AM
thiemowmde mentioned this in T298278: Broken links between marker and footnote when name contains certain HTML entities.Jan 3 2022, 12:45 PM
Bugreporter mentioned this in T349498: Routed hash links conflict with section title links (when titled /editor/0 or #/media/File:Foo.jpg).Feb 1 2024, 7:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL