Scribunto_LuaStandaloneInterpreterTest::testGetStatus fails on PHP 7.1+
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Feb 2 2018, 5:05 AM

Description

There was 1 error:

1) Scribunto_LuaStandaloneInterpreterTest::testGetStatus
A non well formed numeric value encountered

/srv/mediawiki/core/extensions/Scribunto/tests/phpunit/engines/LuaStandalone/LuaStandaloneInterpreterTest.php:25
/srv/mediawiki/core/extensions/Scribunto/tests/phpunit/engines/LuaStandalone/LuaStandaloneInterpreterTest.php:68
/srv/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:421
/srv/mediawiki/core/maintenance/doMaintenance.php:94

This is due to https://wiki.php.net/rfc/invalid_strings_in_arithmetic

(I only tested on 7.2 and 7.0, haven't verified 7.1)

Details

	Subject	Repo	Branch	Lines +/-
	Fix Scribunto_LuaStandaloneInterpreterTest::testGetStatus on 7.1+	mediawiki/extensions/Scribunto	master	+1 -1

Customize query in gerrit

Event Timeline

Legoktm created this task.Feb 2 2018, 5:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2018, 5:05 AM

Change 407582 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Scribunto@master] Fix Scribunto_LuaStandaloneInterpreterTest::testGetStatus on 7.1

https://gerrit.wikimedia.org/r/407582

gerritbot added a project: Patch-For-Review.Feb 2 2018, 5:08 AM

Change 407582 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Fix Scribunto_LuaStandaloneInterpreterTest::testGetStatus on 7.1

https://gerrit.wikimedia.org/r/407582

Legoktm closed this task as Resolved.Feb 2 2018, 10:24 AM

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Feb 2 2018, 11:00 AM

Scribunto_LuaStandaloneInterpreterTest::testGetStatus fails on PHP 7.1+Closed, ResolvedPublicActions

Description

Details

Event Timeline

Scribunto_LuaStandaloneInterpreterTest::testGetStatus fails on PHP 7.1+
Closed, ResolvedPublic
Actions