Page MenuHomePhabricator

Scribunto_LuaStandaloneInterpreterTest::testGetStatus fails on PHP 7.1+
Closed, ResolvedPublic

Description

There was 1 error:

1) Scribunto_LuaStandaloneInterpreterTest::testGetStatus
A non well formed numeric value encountered

/srv/mediawiki/core/extensions/Scribunto/tests/phpunit/engines/LuaStandalone/LuaStandaloneInterpreterTest.php:25
/srv/mediawiki/core/extensions/Scribunto/tests/phpunit/engines/LuaStandalone/LuaStandaloneInterpreterTest.php:68
/srv/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:421
/srv/mediawiki/core/maintenance/doMaintenance.php:94

This is due to https://wiki.php.net/rfc/invalid_strings_in_arithmetic

(I only tested on 7.2 and 7.0, haven't verified 7.1)

Details

Related Gerrit Patches:

Event Timeline

Legoktm created this task.Feb 2 2018, 5:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2018, 5:05 AM

Change 407582 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Scribunto@master] Fix Scribunto_LuaStandaloneInterpreterTest::testGetStatus on 7.1

https://gerrit.wikimedia.org/r/407582

Change 407582 merged by jenkins-bot:
[mediawiki/extensions/Scribunto@master] Fix Scribunto_LuaStandaloneInterpreterTest::testGetStatus on 7.1

https://gerrit.wikimedia.org/r/407582

Legoktm closed this task as Resolved.Feb 2 2018, 10:24 AM