phan tests for MassMessage?
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MarcoAurelio
	Feb 2 2018, 11:20 AM

Description

@WMDE-Fisch suggested some days ago that maybe having CI phan tests for MassMessage would be a good idea. Since I'm not an expert here, I could use some opinions. Regards.

Details

	Subject	Repo	Branch	Lines +/-
	Adding Phan to MassMessage extension	mediawiki/extensions/MassMessage	master	+389 -5

Customize query in gerrit

Related Objects

Mentioned In: T178431: MassMessage technical debt cleanup/refactoring

Event Timeline

MarcoAurelio created this task.Feb 2 2018, 11:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2018, 11:20 AM

Was while we reviewed https://gerrit.wikimedia.org/r/#/c/406988/ with @Mainframe98 as well :-)

Setting up phan is not a big thing and you could then run it with every patch on the CI. And I could at least help you with reviews. :-)

Running phan locally might be a bit tricky, but you could first add it to the experimental part in the CI and then test it there until you're satisfied and have the initial fixes / suppressed warnings set up.

I asked @Noella94 to do this as part of her outreachy project :-)

Great! :-)

Noella94 mentioned this in T178431: MassMessage technical debt cleanup/refactoring.Feb 3 2018, 11:14 AM

Change 408440 had a related patch set uploaded (by Legoktm; owner: Noella94):
[mediawiki/extensions/MassMessage@master] Adding Phan to MassMessage extension

https://gerrit.wikimedia.org/r/408440

gerritbot added a project: Patch-For-Review.Feb 13 2018, 4:02 PM

Change 408440 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Adding Phan to MassMessage extension

https://gerrit.wikimedia.org/r/408440

Legoktm closed this task as Resolved.Feb 13 2018, 4:22 PM

Legoktm assigned this task to Noella94.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 13 2018, 5:00 PM

Thanks!