solve_disambiguation_tests are failing with AssertionError: source parameter should be either a Site or Page object
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dalba
	Feb 2 2018, 12:16 PM

Description

https://travis-ci.org/wikimedia/pywikibot/jobs/336514923#L4758

======================================================================
FAIL: test_get (tests.solve_disambiguation_tests.TestGettingDisambigLinks)
Test getting disambiguation links.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/wikimedia/pywikibot/tests/solve_disambiguation_tests.py", line 31, in test_get
    pywikibot.Link(self.site, 'Link1'),
  File "/home/travis/build/wikimedia/pywikibot/pywikibot/page.py", line 5364, in __init__
    "source parameter should be either a Site or Page object"
AssertionError: source parameter should be either a Site or Page object
======================================================================
FAIL: test_get_without_templates (tests.solve_disambiguation_tests.TestGettingDisambigLinks)
Test excluding links from disamb_templates.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/wikimedia/pywikibot/tests/solve_disambiguation_tests.py", line 42, in test_get_without_templates
    links = [pywikibot.Link(self.site, 'Link1')]
  File "/home/travis/build/wikimedia/pywikibot/pywikibot/page.py", line 5364, in __init__
    "source parameter should be either a Site or Page object"
AssertionError: source parameter should be either a Site or Page object

Details

Project	Branch	Lines +/-	Subject
pywikibot/core	master	+7 -128	Revert "[IMPR] Exclude links in disambiguation templates from possibilities"
pywikibot/core	master	+2 -4	[bugfix][TEST] Fix broken solve_disambiguation.py test
pywikibot/core	master	+3 -3	[bugfix][TEST] Fix broken solve_disambiguation.py test

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T151110 RFC: Regressions of core should be rethought or solved
Resolved	Dvorapa	T186394 solve_disambiguation uses slice operator for PageGenerator
Open	None	T118719 solve_disambiguation.py gives possibilities from {{disambiguation}}
Resolved	Xqt	T186316 solve_disambiguation_tests are failing with AssertionError: source parameter should be either a Site or Page object

Event Timeline

Dalba created this task.Feb 2 2018, 12:16 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptFeb 2 2018, 12:16 PM

Dalba triaged this task as High priority.Feb 2 2018, 12:16 PM

Dalba renamed this task from Travis builds are failing with AssertionError: source parameter should be either a Site or Page object to solve_disambiguation_tests are failing with AssertionError: source parameter should be either a Site or Page object.Feb 2 2018, 12:18 PM

Dvorapa added a parent task: T118719: solve_disambiguation.py gives possibilities from {{disambiguation}}.Feb 2 2018, 12:25 PM

Dvorapa added a subscriber: Dvorapa.

Why self.site isn't a Site object? unittest library in Python is sometimes so unintuitive..

The site should be created by the DisambiguationRobot initializer. Is it?

Well, it should be.. https://phabricator.wikimedia.org/diffusion/PWBC/browse/master/scripts/solve_disambiguation.py;20f5463cd2fed1d99fab88fd391940a3e0695d00$674

It seems to me as if unittest correctly handles family and code into correct Site object (line 25 is OK), but DisambiguationRobot or get_disambiguation_links breaks Site or redefine Site not correctly somehow.

The first argument of pywikibot.Link should be text. The second argument is the source.

:facepalm:

Change 407631 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix][TEST] Fix broken solve_disambiguation.py test

https://gerrit.wikimedia.org/r/407631

gerritbot added a project: Patch-For-Review.Feb 2 2018, 12:56 PM

Change 407631 merged by jenkins-bot:
[pywikibot/core@master] [bugfix][TEST] Fix broken solve_disambiguation.py test

https://gerrit.wikimedia.org/r/407631

Change 407717 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix][TEST] Fix broken solve_disambiguation.py test

https://gerrit.wikimedia.org/r/407717

Change 407717 merged by jenkins-bot:
[pywikibot/core@master] [bugfix][TEST] Fix broken solve_disambiguation.py test

https://gerrit.wikimedia.org/r/407717

Patch reverted with https://gerrit.wikimedia.org/r/#/c/407889/

solve_disambiguation_tests are failing with AssertionError: source parameter should be either a Site or Page objectClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

solve_disambiguation_tests are failing with AssertionError: source parameter should be either a Site or Page object
Closed, ResolvedPublic
Actions

Related Objects
Search...