Page MenuHomePhabricator
Create Task
Maniphest T186329

CodeEditor find and replace should respect editor directionality, not site directionality.
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

On RTL wikis, CodeEditor pages are still LTR, so the find and replace box should be as well.

image.png (560×248 px, 24 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use correct directionality for nested inputs (e.g. find & replace)mediawiki/extensions/CodeEditormaster+6 -0
Customize query in gerrit

Event Timeline

Esanders created this task.Feb 2 2018, 4:13 PM
Restricted Application added a project: I18n. · View Herald TranscriptFeb 2 2018, 4:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.Feb 2 2018, 4:15 PM

Change 407661 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeEditor@master] Use correct directionality for nested inputs (e.g. find & replace)

https://gerrit.wikimedia.org/r/407661

gerritbot added a project: Patch-For-Review.Feb 2 2018, 4:15 PM
Jdforrester-WMF closed this task as Resolved.Feb 2 2018, 6:28 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added a project: VisualEditor.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 2 2018, 6:28 PM
gerritbot added a comment.Feb 2 2018, 6:41 PM

Change 407661 merged by jenkins-bot:
[mediawiki/extensions/CodeEditor@master] Use correct directionality for nested inputs (e.g. find & replace)

https://gerrit.wikimedia.org/r/407661

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Feb 2 2018, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits