Page MenuHomePhabricator

Redesign revision-related event schemas for MCR
Open, LowPublic

Description

Currently the revision-create and revision-visibility-change event schemas contain fields like rev_content_model and rev_content_format but with multi-content revisions that's not enough cause all the slots might have their own model and format. Also, some other properties might make more sense per-slot.

I suppose that the existing field's documentation should be updated to reflect the fact that these are for the main slot. We might consider doing a backward incompatible change and rename the properties, but it's not advisable. Additional properties should be added to describe other slots as well.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

We might consider doing a backward incompatible change and rename the properties, but it's not advisable. Additional properties should be added to describe other slots as well.

rev_content_model and rev_content_format are not required, so we could just figure out new fields that work with multiple slots and eventually stop populating out these fields. Or duplicate the main slot content types into these ones. Ooooook!

Nuria added a subscriber: JAllemandou.
Pchelolo lowered the priority of this task from Medium to Low.Jul 17 2019, 2:59 AM

Setting the priority to low for now since we don't have any real use-cases for MCR aware revision related events.

Restricted Application edited projects, added Analytics; removed Analytics-Radar. · View Herald TranscriptJun 10 2020, 6:33 AM
Restricted Application edited projects, added Analytics; removed Analytics-Radar. · View Herald TranscriptJun 10 2020, 6:36 AM