Page MenuHomePhabricator

Polygerrit should fold not current line comments by default
Open, Needs TriagePublic

Description

Steps to reproduce

  1. Open Gerrit, click the bottom link "New UI", click any patch with many line comments

Expected behavior
The line comments were folded in the old UI, except the most recent ones. This is good behavior, when you first see some patch and want to get general overlook, what was done (patches), what was discussed (comments, line comments), what were ratings from reviewers or jenkins bot.

Current behavior
In Polygerrit these are unfolded. This accentuates the line comments over other history of patch. But these comments can be already solved or answerred, so accentuation of the older ones doesn't make sense.

Configuration
Firefox 58, Gnome on Archlinux

Event Timeline

Dvorapa created this task.Feb 3 2018, 12:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 3 2018, 12:48 PM
Paladox moved this task from Bugs & stuff to PolyGerrit on the Gerrit board.Feb 3 2018, 1:26 PM
Paladox added a subscriber: Paladox.

Filled upstream https://bugs.chromium.org/p/gerrit/issues/detail?id=8276 we will most likly get a comment on it next week (no promises though) but new ui comes a dedicated team for it now.

Thank you, let's wait then

@Dvorapa from upstream "Can you give us a reproducible example where there are comments we should consider automatically collapsing?"

Dvorapa added a comment.EditedFeb 9 2018, 7:23 PM

I tested polygerrit on this one: https://gerrit.wikimedia.org/r/c/372064/, but it has got no so many line comments as some older ones I can not find currently. I want generally see how +1 and -1 was added by reviewers in history of patchsets or how jenkins tests went for every patchset - general overlook. In the old ui I just open the page and immediately I can see. In polygerrit I have to click to Show all 65 messages (this is ok to me), but I see comments are automatically expanded. In old ui they were automatically collapsed. Today I noticed Expand all button, but it requires two more extra clicks ( > Expand all > Collapse all) to collapse the comments. So finally I have to make three extra clicks every time I want to see general overlook about the history of patchsets (+1/-1, jenkins/zuul tests, ...). I understand the first one (Show all 65 messages, makes sense, skip old and see current work), but the two other clicks, not needed in old ui, are just too much.

Thanks, will forward your comment upstream.

Dvorapa added a comment.EditedFeb 9 2018, 7:32 PM

Another issue I can see (should go to separate task) is that in old ui the patchset numbers were lined up one under another, in polygerrit I have to search for the patchset number on every line. Not as drastic change and I think I can get used to this, hopefully just a force of habit (thus not creating another task)