Page MenuHomePhabricator
Create Task
Maniphest T186427

Special:UploadWizard Campaigns broken when EventLogging extension is not enabled
Closed, ResolvedPublic
Actions

Description

When trying to save a Campaign page on REL1_30 I am getting an error.

PHP Fatal error: Class 'EventLogging' not found in .../extensions/UploadWizard/includes/CampaignContent.php on line 49

See T143092.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Validate campaigns without EventLoggingSimon04mediawiki/extensions/UploadWizardREL1_45+133 -30
Validate campaigns without EventLoggingSimon04mediawiki/extensions/UploadWizardREL1_43+133 -30
Validate campaigns without EventLoggingSimon04mediawiki/extensions/UploadWizardREL1_46+133 -30
zuul: Drop EventLogging from UploadWizard dependenciesSimon04integration/configmaster+0 -1
Validate all items of lists in campaignsSimon04mediawiki/extensions/UploadWizardmaster+121 -133
Validate campaigns without EventLoggingSimon04mediawiki/extensions/UploadWizardmaster+133 -36
Customize query in gerrit

Related Objects

Event Timeline

Prod created this task.Feb 3 2018, 8:36 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 3 2018, 8:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Aklapper added a comment.Feb 5 2018, 2:48 PM

Maybe https://phabricator.wikimedia.org/diffusion/EUWI/browse/master/extension.json;28cc296cccdc34e5fe5cdbacb8a4a88ad3a2ebb3$21
just needs something like

 	"requires": {
		"MediaWiki": ">= 1.27.0",
		"extensions": {
			"EventLogging": "*"
		}
	},

?

Prod added a comment.Feb 5 2018, 4:43 PM

Doesn't that mean that EventLogging would be a required extension for UploadWizard then? Shouldn't it be possible to use UploadWizard campaigns without installing EventLogging?

Ostrzyciel mentioned this in T275157: Remove dependency on EventLogging.Feb 18 2021, 8:16 PM
gerritbot added a comment.Fri, Oct 2, 5:25 PM

Change #1348843 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/UploadWizard@master] Validate campaigns without EventLogging

https://gerrit.wikimedia.org/r/1348843

gerritbot added a project: Patch-For-Review.Fri, Oct 2, 5:25 PM
simon04 claimed this task.Fri, Oct 2, 7:55 PM
simon04 moved this task from Backlog to Campaign on the UploadWizard board.Sat, Oct 3, 7:00 AM
gerritbot added a comment.Sat, Oct 3, 2:33 PM

Change #1350078 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/UploadWizard@master] Validate all items of lists in campaigns

https://gerrit.wikimedia.org/r/1350078

gerritbot added a comment.Sat, Oct 3, 2:37 PM

Change #1350083 had a related patch set uploaded (by Simon04; author: Simon04):

[integration/config@master] zuul: Drop EventLogging from UploadWizard dependencies

https://gerrit.wikimedia.org/r/1350083

gerritbot added a comment.Sat, Oct 3, 4:17 PM

Change #1348843 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Validate campaigns without EventLogging

https://gerrit.wikimedia.org/r/1348843

gerritbot added a comment.Sat, Oct 3, 4:17 PM

Change #1350078 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Validate all items of lists in campaigns

https://gerrit.wikimedia.org/r/1350078

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.23; 2026-10-06).Sat, Oct 3, 5:00 PM
gerritbot added a comment.Mon, Oct 5, 8:49 PM

Change #1351485 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/UploadWizard@REL1_46] Validate campaigns without EventLogging

https://gerrit.wikimedia.org/r/1351485

gerritbot added a comment.Mon, Oct 5, 8:49 PM

Change #1351486 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/UploadWizard@REL1_45] Validate campaigns without EventLogging

https://gerrit.wikimedia.org/r/1351486

gerritbot added a comment.Mon, Oct 5, 8:49 PM

Change #1351487 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/UploadWizard@REL1_43] Validate campaigns without EventLogging

https://gerrit.wikimedia.org/r/1351487

gerritbot added a comment.Mon, Oct 5, 10:55 PM

Change #1351486 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@REL1_45] Validate campaigns without EventLogging

https://gerrit.wikimedia.org/r/1351486

gerritbot added a comment.Mon, Oct 5, 10:55 PM

Change #1351487 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@REL1_43] Validate campaigns without EventLogging

https://gerrit.wikimedia.org/r/1351487

gerritbot added a comment.Mon, Oct 5, 10:55 PM

Change #1351485 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@REL1_46] Validate campaigns without EventLogging

https://gerrit.wikimedia.org/r/1351485

gerritbot added a comment.Mon, Oct 5, 11:03 PM

Change #1350083 merged by jenkins-bot:

[integration/config@master] zuul: Drop EventLogging from UploadWizard dependencies

https://gerrit.wikimedia.org/r/1350083

Maintenance_bot removed a project: Patch-For-Review.Mon, Oct 5, 11:30 PM
simon04 closed this task as Resolved.Tue, Oct 6, 9:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits