Thumbor failing on some SVGs with "ValueError: invalid literal for int() with base 10"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Gilles
	Feb 5 2018, 10:36 AM

Project Tags

Referenced Files

None

Subscribers

Description

Exception thrown by

self.internal_size = map(int, self.exif['ImageSize'].split('x')) in imagemagick.py

Example affected file: https://commons.wikimedia.org/wiki/File:Tree_edges.svg

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Upgrade to 1.12	Gilles	operations/debs/python-thumbor-wikimedia	master	+228 -4

Customize query in gerrit

Revisions and Commits

rTHMBREXT Thumbor Plugins
		rTHMBREXT3d0030df230f Version bump
	Restricted Differential Revision	rTHMBREXTbf52dbeba4a7 Allow SVGs starting with a UTF-8 BOM

Related Objects

Mentioned In: T186492: Improve Thumbor error logging
T186594: Log time when request makes it to Thumbor
Mentioned Here: T186492: Improve Thumbor error logging
T186594: Log time when request makes it to Thumbor

Event Timeline

• Gilles created this task.Feb 5 2018, 10:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2018, 10:36 AM

Turns out that this file starts with some invisible characters before the <?xml, which makes it fall back to the default attempt of rendering through the imagemagick engine - not knowing what kind of file we're dealing with - and that in turns fails in this particular way (but would fail later by being unable to convert the image anyway).

The invisible characters are simply UTF-8 encoded BOM. Which means that this might be a valid file still and that's the issue to solve. It's probably a good idea to skip the BOM in general, for all file types.

• Gilles triaged this task as Low priority.Feb 5 2018, 1:37 PM

• Gilles added a revision: Restricted Differential Revision.Feb 5 2018, 1:38 PM

• Gilles added a project: Patch-For-Review.Feb 5 2018, 1:38 PM

• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Feb 5 2018, 9:08 PM

• Gilles added a commit: rTHMBREXTbf52dbeba4a7: Allow SVGs starting with a UTF-8 BOM.Feb 9 2018, 11:36 AM

• Gilles added a commit: rTHMBREXT3d0030df230f: Version bump.Feb 9 2018, 11:39 AM

Change 409314 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.12

https://gerrit.wikimedia.org/r/409314

Change 409314 merged by Filippo Giunchedi:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.12

https://gerrit.wikimedia.org/r/409314

Mentioned in SAL (#wikimedia-operations) [2018-02-12T15:00:58Z] <godog> roll-upgrade thumbor to 1.12 - T186500 T186594 T186492

Stashbot mentioned this in T186594: Log time when request makes it to Thumbor.Feb 12 2018, 3:01 PM

Stashbot mentioned this in T186492: Improve Thumbor error logging.

• Gilles closed this task as Resolved.Feb 12 2018, 3:32 PM

Thumbor failing on some SVGs with "ValueError: invalid literal for int() with base 10"Closed, ResolvedPublicActions