Page MenuHomePhabricator

Provide a list of applicant's other recent applications on review page
Closed, ResolvedPublic

Description

Task

When reviewing an open application it is useful for coordinators to be able to see what other applications that user has made recently. Sometimes a user will apply for 10 different partners at once - the coordinator would find this information useful when deciding if they should be given priority for the resources they are providing access to.

For data privacy reasons coordinators probably shouldn't be able to browse those applications, just see that they were made.

  • Update the review page view (EvaluateApplicationView) with a list of the applicants 5 most recent applications
  • Update the review template (application_evaluation.html) to list those 5 applications and their status (e.g. Open, Approved, Sent)
  • If an application is to a partner the current user (i.e. the coordinator) is the assigned coordinator for, link it.

Good first bug

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Event Timeline

Samwalton9 moved this task from Incoming tasks to Open tasks on the Library-Card-Platform board.
Samwalton9 renamed this task from Provide a link of or list to applicant's other recent applications on review page to Provide a list of applicant's other recent applications on review page.Jul 13 2018, 1:32 PM
Samwalton9 updated the task description. (Show Details)

Hi @Samwalton9! This is just a thank you note for you for being such an amazing mentor all through my contribution to TWLight or hashtags. Thanks for making these projects as beginner-friendly as possible. Thanks for all the appreciations on my PRs and motivating me to contribute more. It was a great learning experience on TWLight with your explanation to solutions and laying out the problem to as simple as possible whenever I got stuck. These days I am working on Dahboard and hopefully will apply for GSoC 2020 that's the reason I was not able to contribute here. But this was my first open-source project and I really enjoyed working on it. I'll still be contributing to it on my university vacations, free time or whenever I'll feel improving my Django skills and would highly recommend this project to my juniors or any beginner to open-source. Thanks a lot :)

No problem at all @Soumyaa1804! Thank you for your contributions to the tool. Good luck for GSoC 2020!

I would like to work on this task.

How do I setup the repository , I cannot find a github link. Please post the link here :)

@lorik: Hi, please see the "Tags" section in this task. https://phabricator.wikimedia.org/project/profile/2765/ links to the code repository. Thanks!

Hi @lorik - have you made any progress on this? Any questions?

Can I work on this one @Samwalton9

  • If an application is to a partner the current user (i.e. the coordinator) is the assigned coordinator for, link it.

also I could not understand this point completely

Samwalton9 added a subscriber: lorik.

also I could not understand this point completely

Imagine we have two partners, Partner A and Partner B. Partner A is coordinated by User 1 and Partner B is coordinated by User 2.

An editor applies to bother partners. User 1 will review the application to Partner A. User 2 will review the application to Partner B. But they can only view the application evaluation page for the applications to their respective partners, not the other.

So when we show the list of applications on the application to Partner A, User 1 shouldn't see a link to the application for Partner B, because they would get a Permission Denied error.

If there was a Partner C, that User 1 also coordinated, we could link that - because User 1 has permission to view it.

Thank you for the explanation, It is very clear now :)

Hello @Samwalton9 raised a PR for this at https://github.com/WikipediaLibrary/TWLight/pull/453

Implemented these 2

  • Update the review page view (EvaluateApplicationView) with a list of the applicants 5 most recent applications
  • Update the review template (application_evaluation.html) to list those 5 applications and their status (e.g. Open, Approved, Sent)

Small doubt, should we check for this condition in 5 recent applications or it can be older than that?

  • If an application is to a partner the current user (i.e. the coordinator) is the assigned coordinator for, link it.

Small doubt, should we check for this condition in 5 recent applications or it can be older than that?

Just for the 5 recent applications being shown - if partner.coordinator for an application is equal to self.request.user or application.editor.user, then hyperlink that entry :)

Just for the 5 recent applications being shown - if partner.coordinator for an application is equal to self.request.user or application.editor.user, then hyperlink that entry :)

  • If an application is to a partner the current user (i.e. the coordinator) is the assigned coordinator for, link it.

Thanks @Samwalton9 I have implemented this behaviour :)

Screen Shot 2020-05-30 at 1.46.13 PM.png (180×749 px, 28 KB)

I have added black-t formatting and the tests are working fine also. But travis-ci check is failing for it currently.
Pull request at https://github.com/WikipediaLibrary/TWLight/pull/453

jsn.sherman added a subscriber: jsn.sherman.

Merged. Sorry for the long wait and thanks for your contribution!

Merged. Sorry for the long wait and thanks for your contribution!

No problem at all. My pleasure as always :)

Nikkimaria added a subscriber: Nikkimaria.

Hi guys, would it be possible to (a) increase the number of apps displayed to 10, particularly if they are made in quick succession, and/or (b) note the total number of apps opened? One use-case for this feature is to alert coordinators to people who've applied to everything indiscriminately, and just seeing five unfortunately doesn't get us there.

Also it looks like these displays aren't limited to recent apps (I just saw someone with 4 Newspapers.com renewals), so could application date also be included in what's shown?

Great point - it didn't occur to me until I saw it in production that dates are an important factor in making use of this list. I've filed a new task since this one was resolved, as written: T262904.