Page MenuHomePhabricator

Opening a Thank notice marks unread revisions of watched page as seen
Open, Needs TriagePublic

Description

Hello. I strongly recommend High priority, despite it is not page content lost, but still, the user loses a lot of information.

  1. User A has page X in their watchlist.
  2. There are a couple (one is enough, but let's say 5) unseen revisions of X.
  3. Before revision 1 there was their own revision of X.
  4. User C thanks to user A for that revision.
  5. User A gets notification about this thank.
  6. User A clicks on notification and opens the thanked revision.
  7. Unexpected result: Revisions 1-5 marked as seen.

Recognized many times, including five minutes ago. But at least once it worked as expected.
Thank you.

Event Timeline

IKhitron created this task.Feb 5 2018, 11:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2018, 11:14 AM
IKhitron updated the task description. (Show Details)Feb 5 2018, 11:16 AM
Aklapper renamed this task from Thank notice opening causes malware marking watched page as seen to Opening a Thank notice marks unread notifications for watched page as seen.Feb 5 2018, 2:42 PM
Quiddity edited projects, added Thanks; removed Notice.Feb 8 2018, 9:23 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 8 2018, 9:23 PM

It seems to me that generally we should not mark a watched page as seen when viewing a diff or a historical version, only when viewing the latest version.

IKhitron renamed this task from Opening a Thank notice marks unread notifications for watched page as seen to Opening a Thank notice marks unread revisions of watched page as seen.Apr 17 2018, 6:48 PM

@Aklapper, I fixed the task name you provided. Sorry that saw the problem so late.

Restricted Application added a project: Maps. · View Herald TranscriptApr 24 2018, 3:18 PM
Restricted Application added a project: Discovery. · View Herald TranscriptApr 24 2018, 3:19 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 2 2018, 11:06 PM