Page MenuHomePhabricator
Create Task
Maniphest T186518

Editor font on TwoColConflict editor too big
Closed, ResolvedPublic
Actions

Description

It seems that due to some change the font size in the two col conflcit editor is bigger that it should be.

Screenshot-2018-2-5 Edit Conflict Simulation - Wikipedia.png (467×1 px, 109 KB)

From feedback in https://www.mediawiki.org/wiki/Topic:U6zl6ocnowwes9fc

Details

SubjectRepoBranchLines +/-
Editor font on TwoColConflict editor too bigmediawiki/extensions/TwoColConflictmaster+0 -1
Customize query in gerrit

Related Objects

Event Timeline

WMDE-Fisch created this task.Feb 5 2018, 2:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2018, 2:27 PM
IKhitron subscribed.Feb 5 2018, 2:40 PM

It's much bigger for me, but seems it depends on browser.

• Lea_WMDE added a project: WMDE-QWERTY-Sprint-2018-02-06.Feb 9 2018, 11:03 AM
• Lea_WMDE moved this task from Proposed to Sprint backlog on the WMDE-QWERTY-Sprint-2018-02-06 board.
• Lea_WMDE moved this task from Sprint backlog to Proposed on the WMDE-QWERTY-Sprint-2018-02-06 board.
Addshore subscribed.Feb 9 2018, 12:56 PM

I tried to reproduce this in Chrome, Firefox, Opera and edge an didn't manage using the conflict test page.

In https://www.mediawiki.org/w/index.php?title=Topic:U6zl6ocnowwes9fc&topic_showPostId=u71xs62ijznskch6#flow-post-u71xs62ijznskch6 @WMDE-Fisch said that he has managed to reproduce this issue so rather than sinking more time into trying to reproduce it I'll wait for him to tell me what he did!

Andrew-WMDE claimed this task.Feb 12 2018, 2:27 PM
gerritbot subscribed.Feb 12 2018, 2:50 PM

Change 409902 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/TwoColConflict@master] Editor font on TwoColConflict editor too big

https://gerrit.wikimedia.org/r/409902

gerritbot added a project: Patch-For-Review.Feb 12 2018, 2:50 PM
Andrew-WMDE mentioned this in rESCC4a506a548616: Editor font on TwoColConflict editor too big.Feb 12 2018, 2:52 PM
Andrew-WMDE moved this task from Proposed to Review on the WMDE-QWERTY-Sprint-2018-02-06 board.Feb 12 2018, 3:05 PM
Andrew-WMDE mentioned this in rESCC704ea4859fbf: Editor font on TwoColConflict editor too big.Feb 12 2018, 3:54 PM
WMDE-Fisch mentioned this in rESCC079e37efd42d: Editor font on TwoColConflict editor too big.Feb 20 2018, 1:43 PM
gerritbot added a comment.Feb 20 2018, 1:46 PM

Change 409902 merged by WMDE-Fisch:
[mediawiki/extensions/TwoColConflict@master] Editor font on TwoColConflict editor too big

https://gerrit.wikimedia.org/r/409902

WMDE-Fisch moved this task from Review to Done on the WMDE-QWERTY-Sprint-2018-02-06 board.Feb 20 2018, 1:47 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 20 2018, 2:00 PM
Tobi_WMDE_SW closed this task as Resolved.Feb 20 2018, 3:18 PM
Tobi_WMDE_SW added a project: WMDE-TechWish.Feb 20 2018, 3:35 PM
Tobi_WMDE_SW moved this task from Proposed to Demoed on the WMDE-TechWish board.Feb 20 2018, 4:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits