Thumbor Swift authentication support for videos
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Gilles
	Feb 5 2018, 3:13 PM

Description

Because the video loader has ffprobe/ffmpeg pointed directly at https URLs of objects stored in swift, it doesn't support authentication, which is required for files stored in temp folders.

Ideally we would auth into swift when dealing with temp URLs and pass the required cookies/headers to the ffprobe/ffmpeg commands.

Details

	Subject	Repo	Branch	Lines +/-
	Upgrade to 1.16	operations/debs/python-thumbor-wikimedia	master	+137 -22

Customize query in gerrit

Revisions and Commits

rTHMBREXT Thumbor Plugins
		rTHMBREXTd234060d1c06 Version bump
		rTHMBREXT8c1ed22137d2 Fix video test
	D1004	rTHMBREXT9658da32528d Add swift authentication to video loader

Related Objects

Mentioned In: T191028: Thumbor incorrectly normalizes .jpe and .jpeg into .jpg for Swift thumbnail storage
T189647: Thumbor missing log extras when hitting ImageMagicException
T179200: Some half-broken PNGs cannot be rendered with the Jessie IM version
Mentioned Here: T179200: Some half-broken PNGs cannot be rendered with the Jessie IM version
T189647: Thumbor missing log extras when hitting ImageMagicException
T191028: Thumbor incorrectly normalizes .jpe and .jpeg into .jpg for Swift thumbnail storage

Event Timeline

• Gilles created this task.Feb 5 2018, 3:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2018, 3:13 PM

• Gilles triaged this task as Low priority.Feb 5 2018, 3:13 PM

• Gilles updated the task description. (Show Details)

• Gilles moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Feb 5 2018, 9:07 PM

Just realized that this affects private wikis. We hadn't hit it yet, given how little videos we have stored there, but still: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.03.13/logback?id=AWIenanRXDoVG7yN2CRu&_g=()

• Gilles renamed this task from Thumbor doesn't support thumbnailing temp video files to Thumbor Swift authentication support for videos.Mar 13 2018, 9:09 AM

• Gilles added a revision: D1004: Add swift authentication to video loader.Mar 13 2018, 10:08 AM

• Gilles added a project: Patch-For-Review.Mar 13 2018, 10:08 AM

• Gilles added a commit: rTHMBREXT9658da32528d: Add swift authentication to video loader.Mar 13 2018, 12:57 PM

Change 419172 had a related patch set uploaded (by Gilles; owner: Gilles):
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.16

https://gerrit.wikimedia.org/r/419172

• Gilles added a commit: rTHMBREXT8c1ed22137d2: Fix video test.Mar 13 2018, 1:07 PM

• Gilles added a commit: rTHMBREXTd234060d1c06: Version bump.

• Gilles moved this task from Backlog to Doing on the Thumbor board.Mar 14 2018, 10:23 AM

Change 419172 merged by Filippo Giunchedi:
[operations/debs/python-thumbor-wikimedia@master] Upgrade to 1.16

https://gerrit.wikimedia.org/r/419172

Mentioned in SAL (#wikimedia-operations) [2018-04-03T09:51:53Z] <godog> deploy thumbor 1.16 in codfw and eqiad - T186528 T179200 T189647 T191028