Page MenuHomePhabricator

tools-services-01: issue with aptly repo release file
Closed, ResolvedPublic

Description

In the Release published by the aptly repo of tools-services-01 there is some issue.

This is what apt-cache policy reports:

1500 http://tools-services-01.tools.eqiad.wmflabs/repo/ trusty-tools/main amd64 Packages
     release o=. trusty-tools,n=trusty-tools,l=. trusty-tools,c=main
     origin tools-services-01.tools.eqiad.wmflabs

The o= and l= properties are weird. Let's review this, since this may cause some issue with code that works with repositories (like T181647)

Event Timeline

aborrero triaged this task as Medium priority.Feb 5 2018, 5:24 PM

Mentioned in SAL (#wikimedia-cloud) [2018-02-05T17:58:45Z] <arturo> publishing/unpublishing trusty-tools repo in tools-services-01 to address T186539

This line gets the o= and l= lines right:

% sudo aptly -architectures=amd64,all -skip-signing -origin=Wikimedia -label='trusty-tools' -distribution='trusty-tools' -component=main publish repo trusty-tools

This generates a Release file like this:

Origin: Wikimedia
Label: trusty-tools
Codename: trusty-tools
Date: Mon, 5 Feb 2018 17:58:09 UTC
Architectures: all amd64
Components: main
Description: Generated by aptly
[...]

And apt-cache policysees:

1500 http://tools-services-01.tools.eqiad.wmflabs/repo/ trusty-tools/main amd64 Packages
     release o=Wikimedia,n=trusty-tools,l=trusty-tools,c=main
     origin tools-services-01.tools.eqiad.wmflabs

This still lacks some fields, like Suite: and Version:, which are important information from a repository.

Comparing it to some official repo:

500 http://security.ubuntu.com/ubuntu/ trusty-security/main amd64 Packages
    release v=14.04,o=Ubuntu,a=trusty-security,n=trusty,l=Ubuntu,c=main
    origin security.ubuntu.com

The v= and a= components are included, which aptly v0.8 doesn't seem to support.

I just asked @akosiaris to bump aptly to >v0.9 in trusty-wikimedia in apt.wikimedia.org to see if we can fix this

Can't aptly (whichever version) become part of trusty-tools instead? That would remove the interdependency with production's apt, which seems especially relevant given toolforge has its own ways, apt repository et al.

Mentioned in SAL (#wikimedia-cloud) [2018-02-06T13:03:10Z] <arturo> install aptly v0.9.6-1 in tools-services-01 for T186539 after adding it to trusty-tools repo (self contained)

Change 408529 had a related patch set uploaded (by Arturo Borrero Gonzalez; owner: Arturo Borrero Gonzalez):
[operations/puppet@production] aptly: add more attributes to published repos

https://gerrit.wikimedia.org/r/408529

Change 408529 merged by Arturo Borrero Gonzalez:
[operations/puppet@production] aptly: add more attributes to published repos

https://gerrit.wikimedia.org/r/408529

This seems fixed now.

From apt-cache policy point of view:

1500 http://tools-services-01.tools.eqiad.wmflabs/repo/ trusty-tools/main amd64 Packages
     release o=Wikimedia,a=trusty-tools,n=trusty-tools,l=trusty-tools,c=main
     origin tools-services-01.tools.eqiad.wmflabs