Page MenuHomePhabricator
Create Task
Maniphest T186630

Cannot read property 'length' of null
Closed, ResolvedPublic
Actions

Description

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.02.06/parsoid?id=AWFsXjkMqJPajYV17K8n&_g=()

TypeError: Cannot read property 'length' of null
    at /srv/deployment/parsoid/deploy-cache/revs/211ea5db92dd320e99361c697f9153ea8fdaa520/src/lib/parse.js:183:60
    at throw (native)
    at tryCatchThrow (/srv/deployment/parsoid/deploy-cache/revs/211ea5db92dd320e99361c697f9153ea8fdaa520/node_modules/prfun/lib/index.js:791:36)
    at continuer (/srv/deployment/parsoid/deploy-cache/revs/211ea5db92dd320e99361c697f9153ea8fdaa520/node_modules/prfun/lib/index.js:800:24)
    at errback (/srv/deployment/parsoid/deploy-cache/revs/211ea5db92dd320e99361c697f9153ea8fdaa520/node_modules/prfun/lib/index.js:813:40)
    at tryCatch1 (/srv/deployment/parsoid/deploy-cache/revs/211ea5db92dd320e99361c697f9153ea8fdaa520/node_modules/babybird/lib/promise.js:40:12)
    at promiseReactionJob (/srv/deployment/parsoid/deploy-cache/revs/211ea5db92dd320e99361c697f9153ea8fdaa520/node_modules/babybird/lib/promise.js:269:19)
    at PromiseReactionJobTask.call (/srv/deployment/parsoid/deploy-cache/revs/211ea5db92dd320e99361c697f9153ea8fdaa520/node_modules/babybird/lib/promise.js:284:3)
    at flush (/srv/deployment/parsoid/deploy-cache/revs/211ea5db92dd320e99361c697f9153ea8fdaa520/node_modules/asap/raw.js:50:29)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)

from ptwiki/La_Chapelle-Saint-Sulpice

Details

SubjectRepoBranchLines +/-
Don't try to bump parser resource use if setPageSrcInfo is throwing exceptionsmediawiki/services/parsoidmaster+3 -6
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Feb 6 2018, 6:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2018, 6:50 PM
Arlolra triaged this task as High priority.Feb 6 2018, 6:50 PM
Arlolra claimed this task.Feb 6 2018, 7:06 PM
cscott subscribed.Feb 6 2018, 7:48 PM

Erk, is this my fault w/ 1f89e97a25b5413d90ad36591d0e5766883c5b25 ?

cscott added a comment.Feb 6 2018, 7:49 PM

Yeah, probably -- the code used to be Promise#tap, so it would still have thrown an exception, but that exception would have been ignored.

Now it's try { } finally { ...stuff... } so the exception in the finally cause propagates out. (Sigh.)

cscott added a comment.Feb 6 2018, 7:54 PM

Patch at https://gerrit.wikimedia.org/r/408593 -- assuming that the underlying failure in setPageSrc would be properly handled by the caller.

gerritbot subscribed.Feb 6 2018, 7:55 PM

Change 408593 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Don't try to bump parser resource use if setPageSrcInfo is throwing exceptions

https://gerrit.wikimedia.org/r/408593

gerritbot added a project: Patch-For-Review.Feb 6 2018, 7:55 PM
gerritbot added a comment.Feb 6 2018, 8:35 PM

Change 408593 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Don't try to bump parser resource use if setPageSrcInfo is throwing exceptions

https://gerrit.wikimedia.org/r/408593

Arlolra closed this task as Resolved.Feb 6 2018, 9:43 PM
Stashbot subscribed.Feb 8 2018, 6:38 PM

Mentioned in SAL (#wikimedia-operations) [2018-02-08T18:38:35Z] <arlolra> Updated Parsoid to 961a5cf (T186630)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL