Page MenuHomePhabricator
Create Task
Maniphest T186703

Browser tests for pagination links
Closed, ResolvedPublic
Actions

Description

Test:
When clicking on the "20, 50, 100" next search result links, the advanced search box still contains the input, and the search results reflect the input

Create test pages if needed

Details

SubjectRepoBranchLines +/-
Make sure pagination links get URL parametersmediawiki/extensions/AdvancedSearchmaster+80 -1
Improve SearchPage togglingmediawiki/extensions/AdvancedSearchmaster+13 -9
Customize query in gerrit

Related Objects

Event Timeline

• Tonina_Zhelyazkova_WMDE created this task.Feb 7 2018, 12:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2018, 12:36 PM
• Tonina_Zhelyazkova_WMDE added a project: Advanced-Search.Feb 7 2018, 12:36 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptFeb 7 2018, 12:36 PM
• Tonina_Zhelyazkova_WMDE moved this task from Todo to Doing on the WMDE-Fundraising-Sprint-16 board.Feb 7 2018, 12:36 PM
gabriel-wmde mentioned this in T185191: Investigate browser tested search results.Feb 7 2018, 3:04 PM
gabriel-wmde updated the task description. (Show Details)Feb 7 2018, 4:28 PM
gerritbot subscribed.Feb 7 2018, 4:29 PM

Change 406310 had a related patch set uploaded (by Gabriel Birke; owner: Gabriel Birke):
[mediawiki/extensions/AdvancedSearch@master] Make sure pagination links get URL parameters

https://gerrit.wikimedia.org/r/406310

gerritbot added a project: Patch-For-Review.Feb 7 2018, 4:29 PM
gabriel-wmde mentioned this in rEASR7fe16f84cd48: Make sure pagination links get URL parameters.Feb 7 2018, 4:29 PM
gabriel-wmde mentioned this in rEASR00e89acd829d: Make sure pagination links get URL parameters.Feb 7 2018, 4:32 PM
gabriel-wmde removed gabriel-wmde as the assignee of this task.Feb 7 2018, 4:34 PM
gabriel-wmde moved this task from Doing to Review on the WMDE-Fundraising-Sprint-16 board.
gabriel-wmde subscribed.
• Tonina_Zhelyazkova_WMDE moved this task from Review to Doing on the WMDE-Fundraising-Sprint-16 board.Feb 8 2018, 10:14 AM
gabriel-wmde mentioned this in rEASR1f4d0908f1fd: Make sure pagination links get URL parameters.Feb 8 2018, 1:29 PM
gabriel-wmde mentioned this in rEASRad31190bc82e: Make sure pagination links get URL parameters.Feb 8 2018, 2:20 PM
gabriel-wmde mentioned this in rEASR2021ec0eb53f: Make sure pagination links get URL parameters.Feb 8 2018, 5:22 PM
gabriel-wmde mentioned this in rEASR08b7db7b3e27: Make sure pagination links get URL parameters.Feb 8 2018, 5:30 PM
gerritbot added a comment.Feb 9 2018, 9:07 AM

Change 409024 had a related patch set uploaded (by Gabriel Birke; owner: Gabriel Birke):
[mediawiki/extensions/AdvancedSearch@master] Improve and fix SearchPage

https://gerrit.wikimedia.org/r/409024

gabriel-wmde mentioned this in rEASR3e7bca41c6e8: Improve and fix SearchPage.Feb 9 2018, 9:08 AM
gabriel-wmde added a comment.Feb 9 2018, 9:09 AM

The tests were failing for reasons unrelated to my patch, I've created another PR that addresses the failing tests in master. Please review & Merge that, then I'll rebase the pagination PR.

gabriel-wmde moved this task from Doing to Review on the WMDE-Fundraising-Sprint-16 board.Feb 9 2018, 9:09 AM
gabriel-wmde mentioned this in rEASRc0b26f840f34: Improve SearchPage toggling.Feb 9 2018, 11:48 AM
• Tonina_Zhelyazkova_WMDE claimed this task.Feb 9 2018, 11:57 AM
• Tonina_Zhelyazkova_WMDE removed • Tonina_Zhelyazkova_WMDE as the assignee of this task.Feb 9 2018, 12:19 PM
gabriel-wmde mentioned this in rEASR723257979140: Improve SearchPage toggling.Feb 9 2018, 3:48 PM
• Tonina_Zhelyazkova_WMDE moved this task from Review to Deploy to Test on the WMDE-Fundraising-Sprint-16 board.Feb 9 2018, 3:54 PM
gerritbot added a comment.Feb 9 2018, 3:57 PM

Change 409024 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Improve SearchPage toggling

https://gerrit.wikimedia.org/r/409024

gabriel-wmde mentioned this in rEASRb1344959c3b6: Make sure pagination links get URL parameters.Feb 9 2018, 3:58 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 9 2018, 4:00 PM
• Tonina_Zhelyazkova_WMDE moved this task from Deploy to Test to Review on the WMDE-Fundraising-Sprint-16 board.Feb 12 2018, 10:39 AM
• Tonina_Zhelyazkova_WMDE claimed this task.Feb 12 2018, 10:50 AM
• Tonina_Zhelyazkova_WMDE removed • Tonina_Zhelyazkova_WMDE as the assignee of this task.Feb 12 2018, 1:38 PM
gabriel-wmde mentioned this in rEASRce1e177666af: Make sure pagination links get URL parameters.Feb 13 2018, 3:50 PM
gabriel-wmde mentioned this in rEASRcdc7c7fda71f: Make sure pagination links get URL parameters.Feb 13 2018, 3:57 PM
gabriel-wmde mentioned this in rEASR0e494c1bce35: Make sure pagination links get URL parameters.Feb 13 2018, 4:53 PM
gabriel-wmde mentioned this in rEASR06c7671d7a71: Make sure pagination links get URL parameters.Feb 13 2018, 5:05 PM
gabriel-wmde mentioned this in rEASRfb2540774842: Make sure pagination links get URL parameters.Feb 13 2018, 5:36 PM
gabriel-wmde mentioned this in rEASR47a498e9613b: Make sure pagination links get URL parameters.Feb 13 2018, 5:42 PM
• Tonina_Zhelyazkova_WMDE claimed this task.Feb 14 2018, 8:43 AM
gabriel-wmde mentioned this in rEASRfd141ed69480: Make sure pagination links get URL parameters.Feb 14 2018, 9:07 AM
• Tonina_Zhelyazkova_WMDE removed • Tonina_Zhelyazkova_WMDE as the assignee of this task.Feb 14 2018, 9:14 AM
• Tonina_Zhelyazkova_WMDE moved this task from Review to Deploy to Test on the WMDE-Fundraising-Sprint-16 board.
gerritbot added a comment.Feb 14 2018, 9:18 AM

Change 406310 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Make sure pagination links get URL parameters

https://gerrit.wikimedia.org/r/406310

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)); removed MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 14 2018, 10:00 AM
Lea_WMDE moved this task from Backlog to In FUN sprint on the Advanced-Search board.Feb 14 2018, 10:20 AM
kai.nissen added a project: WMDE-Fundraising-Sprint-17.Feb 14 2018, 12:51 PM
kai.nissen moved this task from Todo to Deploy to Test on the WMDE-Fundraising-Sprint-17 board.
• Tonina_Zhelyazkova_WMDE moved this task from Deploy to Test to Test on the WMDE-Fundraising-Sprint-16 board.Feb 14 2018, 2:07 PM
• Tonina_Zhelyazkova_WMDE moved this task from Test to Done on the WMDE-Fundraising-Sprint-16 board.Feb 14 2018, 2:32 PM
gabriel-wmde closed this task as Resolved.Feb 14 2018, 4:31 PM
gabriel-wmde claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL