Page MenuHomePhabricator
Create Task
Maniphest T186743

Switching from 2010 WTE (e.g. edit conflict) to VE and then to 2017 WTE throws a JS fatal
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Uncaught Error: Another textSelection API was already registered
    at jQuery.fn.init.$.fn.textSelection (<anonymous>:24:105)

Presumably we don't unload the 2010 editor's textSelection code?

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Assume wpTextbox1 has an API registered alreadymediawiki/extensions/VisualEditorwmf/1.31.0-wmf.20+3 -0
Assume wpTextbox1 has an API registered alreadymediawiki/extensions/VisualEditormaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Feb 7 2018, 7:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2018, 7:52 PM
gerritbot subscribed.Feb 7 2018, 8:14 PM

Change 408865 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Assume wpTextbox1 has an API registered already

https://gerrit.wikimedia.org/r/408865

gerritbot added a project: Patch-For-Review.Feb 7 2018, 8:14 PM
Esanders subscribed.EditedFeb 7 2018, 8:15 PM

We don't unload the 2010 editor at all, it doesn't have a concept of unloading...

Jdforrester-WMF added a comment.Feb 7 2018, 8:16 PM
In T186743#3953977, @Esanders wrote:

We don't unload the 2010 editor at all, it doesn't have a concept of unloading...

Lovely.

gerritbot added a comment.Feb 7 2018, 8:29 PM

Change 408865 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Assume wpTextbox1 has an API registered already

https://gerrit.wikimedia.org/r/408865

Esanders merged a task: T186744: Switching from 2010 WTE (e.g. edit conflict) to VE and then to 2017 WTE throws a JS fatal.Feb 7 2018, 8:29 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 7 2018, 9:00 PM
gerritbot added a comment.Feb 7 2018, 9:21 PM

Change 408924 had a related patch set uploaded (by Jforrester; owner: Esanders):
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.20] Assume wpTextbox1 has an API registered already

https://gerrit.wikimedia.org/r/408924

gerritbot added a comment.Feb 8 2018, 12:27 AM

Change 408924 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.31.0-wmf.20] Assume wpTextbox1 has an API registered already

https://gerrit.wikimedia.org/r/408924

Jdforrester-WMF closed this task as Resolved.Feb 8 2018, 12:38 AM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 8 2018, 12:38 AM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 8 2018, 1:00 AM
PerfektesChaos mentioned this in T199051: Improve collaboration between CodeMirror and competitors.Jul 8 2018, 11:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits