Page MenuHomePhabricator

[LOW] Swipe to delete on first item on a date in History should not swipe away date
Closed, ResolvedPublic2 Estimated Story Points

Assigned To
Authored By
RHo
Feb 7 2018, 9:37 PM
Referenced Files
F31075564: Screenshot_1573750677.png
Nov 14 2019, 4:59 PM
F31075567: Screenshot_1573750680.png
Nov 14 2019, 4:59 PM
F31075508: Screenshot_1573749972.png
Nov 14 2019, 4:47 PM
F31064609: Screenshot_1573671867.png
Nov 13 2019, 7:07 PM
F31064607: Screenshot_1573671870.png
Nov 13 2019, 7:07 PM
F31064601: Screenshot_1573671820.png
Nov 13 2019, 7:07 PM
F12893717: Artboard.png
Feb 15 2018, 3:31 PM
F12893704: Artboard.png
Feb 15 2018, 3:31 PM

Description

Steps to reproduce

  1. Open history
  2. Swipe to delete the first article below a date subheading

Expected

Only the list item is swiped off

Artboard.png (1×1 px, 350 KB)

Actual

Date subheading is included in the swipe action, and then reappears after swipe off

image.png (1×1 px, 287 KB)

Occurring on

Wikipedia v2.7.224-alpha-2018-02-06 on Nexus (6.0.1)

Event Timeline

Expected behaviour: date is part of each item, so it gets deleted with the item it's associated with.

Estimate is for changing this behaviour so there is an item for the date as well, which can remain visible.

Charlotte renamed this task from [BUG][LOW] Swipe to delete on first item on a date in History should not swipe away date to [LOW] Swipe to delete on first item on a date in History should not swipe away date.Feb 14 2018, 6:17 PM
Charlotte edited projects, added Android Design; removed Android-app-Bugs.
Charlotte set the point value for this task to 2.

hi @Charlotte @Dbrant - should the date not be a subheading element that is unconnected with the list items? It looks like part of the same bug with Multiple selection in History which was fixed on T185536:

Before:
Artboard.png (640×360 px, 47 KB)
After
Artboard.png (640×360 px, 47 KB)

Yes, that's how it should be. In RecyclerView terminology, the date should be a different type of item in the list; a type that is neither selectable or swipeable.

In that case can we move this to [BUG] or tech debt?

RHo triaged this task as Medium priority.Mar 6 2018, 4:02 PM
RHo removed a project: Android Design.

Hi @schoenbaechler

Would it be better if it uses the same header view style as other lists? Here's the implementation:

Screenshot_1573671820.png (2×1 px, 192 KB)

In "Wikipedia langauges"

Screenshot_1573671870.png (2×1 px, 76 KB)

In "Add a langauge"

Screenshot_1573671867.png (2×1 px, 131 KB)

Hi @cooltey, a very good suggestion. Let’s go with that label style. Would it solve the swiping issue, described in the task’s description as well?

On another note, using accent50 is the wrong color choice for that label, as it’s used for links and CTA’s. Can we de-emphasize it and change its color to color_group_30 / material_theme_secondary_color in the course of this task?

Thanks!

@schoenbaechler

Would it solve the swiping issue, described in the task’s description as well?

Yes :)

On another note, using accent50 is the wrong color choice for that label, as it’s used for links and CTA’s. Can we de-emphasize it and change its color to color_group_30 / material_theme_secondary_color in the course of this task?

No problem

Screenshot_1573749972.png (2×1 px, 437 KB)

As we discussed, I've changed it globally.

Screenshot_1573750677.png (2×1 px, 68 KB)

Screenshot_1573750680.png (2×1 px, 129 KB)