Page MenuHomePhabricator

MobileFrontend mobile.init loadCurrentPage function doesn't pass `isMissing` property
Closed, ResolvedPublic

Description

ronseal

Nice to have:
To detect missing articles use isMissing instead of === 0 checks in MF codebase

Event Timeline

Change 409159 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Hygiene: when building the Page object pass isMissing property

https://gerrit.wikimedia.org/r/409159

Change 409162 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Use page.isMissing instead of checking the page.id

https://gerrit.wikimedia.org/r/409162

Change 409169 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Use page id when determining isMissing logic

https://gerrit.wikimedia.org/r/409169

Change 409159 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: when building the Page object pass isMissing property

https://gerrit.wikimedia.org/r/409159

Change 409162 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Use page.isMissing instead of checking the page.id

https://gerrit.wikimedia.org/r/409162

Change 409169 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Use page id when determining isMissing logic

https://gerrit.wikimedia.org/r/409169